Issue 2767603002: Don't run service tests via dartkp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2767603002: Don't run service tests via dartkp (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't run service tests via dartkp BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/41a8604ebf930ff58d5487c625f11f4b9e0b90fc

Patch Set 1 #

Total comments: 1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/observatory/tests/service/service_kernel.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

lgtm https://codereview.chromium.org/2767603002/diff/1/runtime/observatory/tests/service/service_kernel.status File runtime/observatory/tests/service/service_kernel.status (right): https://codereview.chromium.org/2767603002/diff/1/runtime/observatory/tests/service/service_kernel.status#newcode5 runtime/observatory/tests/service/service_kernel.status:5: [ $compiler == dartkp ] Maybe add a ...

3 years, 9 months ago (2017-03-21 14:09:26 UTC) #3

jensj

3 years, 9 months ago (2017-03-21 14:11:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41a8604ebf930ff58d5487c625f11f4b9e0b90fc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages