Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: content/browser/download/parallel_download_job.h

Issue 2767593003: Handle early pause, cancel for parallel requests. (Closed)
Patch Set: Work on feedback, make DownloadWorker cache some states. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/parallel_download_job.h
diff --git a/content/browser/download/parallel_download_job.h b/content/browser/download/parallel_download_job.h
index f48f80c0f9169349e559b25272e1d376618399fb..19595e2b13429860156dbcd36f830d56b18b6779 100644
--- a/content/browser/download/parallel_download_job.h
+++ b/content/browser/download/parallel_download_job.h
@@ -40,12 +40,16 @@ class CONTENT_EXPORT ParallelDownloadJob : public DownloadJobImpl,
// Virtual for testing.
virtual int GetParallelRequestCount() const;
- private:
- friend class ParallelDownloadJobTest;
-
using WorkerMap =
std::unordered_map<int64_t, std::unique_ptr<DownloadWorker>>;
+ // Map from the offset position of the slice to the worker that downloads the
+ // slice.
+ WorkerMap workers_;
+
+ private:
+ friend class ParallelDownloadJobTest;
+
// DownloadWorker::Delegate implementation.
void OnByteStreamReady(
DownloadWorker* worker,
@@ -75,10 +79,6 @@ class CONTENT_EXPORT ParallelDownloadJob : public DownloadJobImpl,
// the size of the target file if the request starts from non-zero offset.
int64_t content_length_;
- // Map from the offset position of the slice to the worker that downloads the
- // slice.
- WorkerMap workers_;
-
// Used to send parallel requests after a delay based on Finch config.
base::OneShotTimer timer_;

Powered by Google App Engine
This is Rietveld 408576698