Handle early pause, cancel for parallel requests.

content/browser/download/download_job.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "content/browser/byte_stream.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/download_danger_type.h"
 #include "content/public/browser/download_interrupt_reasons.h"
 
 namespace content {
 
 class DownloadItemImpl;
 class WebContents;
 
 // DownloadJob lives on UI thread and subclasses implement actual download logic
 // and interact with DownloadItemImpl.
 // The base class is a friend class of DownloadItemImpl.
 class CONTENT_EXPORT DownloadJob {
  public:
   explicit DownloadJob(DownloadItemImpl* download_item);
   virtual ~DownloadJob();
 
   // Download operations.
   virtual void Start() = 0;
-  virtual void Cancel(bool user_cancel) = 0;
+  virtual void Cancel(bool user_cancel);
   virtual void Pause();
   virtual void Resume(bool resume_request);
 
   bool is_paused() const { return is_paused_; }
+  bool is_canceled() const { return is_canceled_; }

[qinmin, 2017/03/26 05:01:00]

nit: these functions and the private member variables are no longer needed in
the base class

[xingliu, 2017/03/27 17:29:33]

We actually added an is_canceled check in BuildParallelRequest, to not send
messages when the user canceled.

 
   // Return the WebContents associated with the download. Usually used to
   // associate a browser window for any UI that needs to be displayed to the
   // user.
   // Or return nullptr if the download is not associated with an active
   // WebContents.
   virtual WebContents* GetWebContents() const = 0;
 
   // Returns whether the download uses parallel requests.
   virtual bool UsesParallelRequests() const;
 
  protected:
   void StartDownload() const;
   void Interrupt(DownloadInterruptReason reason);
 
-  // Add a byte stream to the download sink.
-  void AddByteStream(std::unique_ptr<ByteStreamReader> stream_reader,
+  // Add a byte stream to the download sink. Return false if we start to
+  // destroy download file.
+  bool AddByteStream(std::unique_ptr<ByteStreamReader> stream_reader,
                      int64_t offset,
                      int64_t length);
 
   DownloadItemImpl* download_item_;
 
  private:
   // If the download progress is paused by the user.
   bool is_paused_;
 
+  // If the download progress is canceled.
+  bool is_canceled_;
+
   DISALLOW_COPY_AND_ASSIGN(DownloadJob);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_