Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: runtime/tools/verbose_gc_to_bmu.dart

Issue 2767533002: Revert "Fix observatory tests broken by running dartfmt." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/spawn_shutdown_test.dart ('k') | runtime/vm/snapshot_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tools/verbose_gc_to_bmu.dart
diff --git a/runtime/tools/verbose_gc_to_bmu.dart b/runtime/tools/verbose_gc_to_bmu.dart
index 20030fa3a4aa018a72b0a1d377a6e1f1f4e851f7..67c160528461927ef7d785e29255af75c2b9ab50 100644
--- a/runtime/tools/verbose_gc_to_bmu.dart
+++ b/runtime/tools/verbose_gc_to_bmu.dart
@@ -56,7 +56,7 @@ class Timeline {
}
return result;
}
-
+
// Returns the fraction of non-pause time, or 1.0 for an invalid interval.
double _utilization(Interval<int> iv) {
if (_run.begin > iv.begin || iv.end > _run.end || iv.length == 0) {
@@ -68,7 +68,7 @@ class Timeline {
}
return 1.0 - (paused / iv.length);
}
-
+
final Interval<int> _run = new Interval<int>(0, 0);
final List<Interval<int>> _pauses = [];
}
@@ -80,7 +80,7 @@ Interval<int> parseVerboseGCLine(String line) {
// Update this (and indices below, if needed) when logging format changes.
if (fields.length != 25) {
assert(line.startsWith('[ GC | space | count | start | gc time') ||
- line.startsWith('[ (isolate)| (reason)| | (s) | (ms) '));
+ line.startsWith('[ (isolate)| (reason)| | (s) | (ms) '));
return new Interval<int>(0, 0);
}
var begin = (1e6 * double.parse(fields[2])).floor();
@@ -99,8 +99,8 @@ void main() {
print('# window_size_ms, bounded_mutator_utilization');
var minimumSeen = 1.0;
for (int w = t._run.length;
- w > 1000 * MINIMUM_WINDOW_SIZE_MS;
- w = (w * WINDOW_STEP_FACTOR).floor()) {
+ w > 1000 * MINIMUM_WINDOW_SIZE_MS;
+ w = (w * WINDOW_STEP_FACTOR).floor()) {
minimumSeen = min(minimumSeen, t.minUtilization(w));
print('${w / 1000}, $minimumSeen');
}
« no previous file with comments | « runtime/tests/vm/dart/spawn_shutdown_test.dart ('k') | runtime/vm/snapshot_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698