Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2531)

Unified Diff: runtime/observatory/tests/service/file_service_test.dart

Issue 2767533002: Revert "Fix observatory tests broken by running dartfmt." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/file_service_test.dart
diff --git a/runtime/observatory/tests/service/file_service_test.dart b/runtime/observatory/tests/service/file_service_test.dart
index 2b455e6f06fc1060ef90c20d209579ec2f700bb8..25500c665f8980fdfc96932dc8ec1eadc48903b0 100644
--- a/runtime/observatory/tests/service/file_service_test.dart
+++ b/runtime/observatory/tests/service/file_service_test.dart
@@ -27,7 +27,7 @@ Future setupFiles() async {
Future<ServiceExtensionResponse> cleanup(ignored_a, ignored_b) {
closeDown();
- var result = JSON.encode({'type': 'foobar'});
+ var result = JSON.encode({'type' : 'foobar'});
return new Future.value(new ServiceExtensionResponse.result(result));
}
@@ -56,14 +56,14 @@ Future setupFiles() async {
var readTemp = new io.File(writeTemp);
var result = await readTemp.readAsString();
expect(result, equals('foobar'));
+
} catch (e) {
closeDown();
throw e;
}
- var result = JSON.encode({'type': 'foobar'});
+ var result = JSON.encode({'type' : 'foobar'});
return new Future.value(new ServiceExtensionResponse.result(result));
}
-
registerExtension('ext.dart.io.cleanup', cleanup);
registerExtension('ext.dart.io.setup', setup);
}
@@ -78,7 +78,7 @@ var fileTests = [
expect(result['data'].length, equals(2));
var writing = await isolate.invokeRpcNoUpgrade(
- 'ext.dart.io.getFileByID', {'id': result['data'][0]['id']});
+ 'ext.dart.io.getFileByID', { 'id' : result['data'][0]['id'] });
expect(writing['totalRead'], equals(0));
expect(writing['readCount'], equals(0));
@@ -88,7 +88,7 @@ var fileTests = [
expect(writing['lastRead'], equals(0));
var reading = await isolate.invokeRpcNoUpgrade(
- 'ext.dart.io.getFileByID', {'id': result['data'][1]['id']});
+ 'ext.dart.io.getFileByID', { 'id' : result['data'][1]['id'] });
expect(reading['totalRead'], equals(5));
expect(reading['readCount'], equals(5));
@@ -96,10 +96,11 @@ var fileTests = [
expect(reading['totalWritten'], equals(0));
expect(reading['lastWrite'], equals(0));
expect(reading['lastRead'], greaterThan(0));
+
} finally {
await isolate.invokeRpcNoUpgrade('ext.dart.io.cleanup', {});
}
},
];
-main(args) async => runIsolateTests(args, fileTests, testeeBefore: setupFiles);
+main(args) async => runIsolateTests(args, fileTests, testeeBefore:setupFiles);
« no previous file with comments | « runtime/observatory/tests/service/field_script_test.dart ('k') | runtime/observatory/tests/service/gc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698