Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: runtime/observatory/tests/service/metrics_test.dart

Issue 2767533002: Revert "Fix observatory tests broken by running dartfmt." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'package:observatory/service_io.dart'; 6 import 'package:observatory/service_io.dart';
7 import 'package:unittest/unittest.dart'; 7 import 'package:unittest/unittest.dart';
8 import 'test_helper.dart'; 8 import 'test_helper.dart';
9 9
10 import 'dart:developer'; 10 import 'dart:developer';
11 11
12 void script() { 12 void script() {
13 var counter = new Counter('a.b.c', 'description'); 13 var counter = new Counter('a.b.c', 'description');
14 Metrics.register(counter); 14 Metrics.register(counter);
15 counter.value = 1234.5; 15 counter.value = 1234.5;
16 } 16 }
17 17
18 var tests = [ 18 var tests = [
19
19 (Isolate isolate) async { 20 (Isolate isolate) async {
20 Map metrics = await isolate.refreshDartMetrics(); 21 Map metrics = await isolate.refreshDartMetrics();
21 expect(metrics.length, equals(1)); 22 expect(metrics.length, equals(1));
22 var counter = metrics['metrics/a.b.c']; 23 var counter = metrics['metrics/a.b.c'];
23 expect(counter.name, equals('a.b.c')); 24 expect(counter.name, equals('a.b.c'));
24 expect(counter.value, equals(1234.5)); 25 expect(counter.value, equals(1234.5));
25 }, 26 },
27
26 (Isolate isolate) async { 28 (Isolate isolate) async {
27 var params = {'metricId': 'metrics/a.b.c'}; 29 var params = { 'metricId': 'metrics/a.b.c' };
28 ServiceMetric counter = 30 ServiceMetric counter =
29 await isolate.invokeRpc('_getIsolateMetric', params); 31 await isolate.invokeRpc('_getIsolateMetric', params);
30 expect(counter.name, equals('a.b.c')); 32 expect(counter.name, equals('a.b.c'));
31 expect(counter.value, equals(1234.5)); 33 expect(counter.value, equals(1234.5));
32 }, 34 },
35
33 (Isolate isolate) async { 36 (Isolate isolate) async {
34 bool caughtException; 37 bool caughtException;
35 try { 38 try {
36 await isolate 39 await isolate.invokeRpc('_getIsolateMetric',
37 .invokeRpc('_getIsolateMetric', {'metricId': 'metrics/a.b.d'}); 40 { 'metricId': 'metrics/a.b.d' });
38 expect(false, isTrue, reason: 'Unreachable'); 41 expect(false, isTrue, reason:'Unreachable');
39 } on ServerRpcException catch (e) { 42 } on ServerRpcException catch (e) {
40 caughtException = true; 43 caughtException = true;
41 expect(e.code, equals(ServerRpcException.kInvalidParams)); 44 expect(e.code, equals(ServerRpcException.kInvalidParams));
42 expect(e.message, 45 expect(e.message,
43 "_getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d"); 46 "_getIsolateMetric: invalid 'metricId' parameter: metrics/a.b.d");
44 } 47 }
45 expect(caughtException, isTrue); 48 expect(caughtException, isTrue);
46 }, 49 },
47 ]; 50 ];
48 51
49 main(args) => runIsolateTests(args, tests, testeeBefore: script); 52 main(args) => runIsolateTests(args, tests, testeeBefore: script);
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/malformed_test.dart ('k') | runtime/observatory/tests/service/mirror_references_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698