Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Side by Side Diff: runtime/observatory/tests/service/dev_fs_http_put_weird_char_test.dart

Issue 2767533002: Revert "Fix observatory tests broken by running dartfmt." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'dart:async'; 6 import 'dart:async';
7 import 'dart:convert'; 7 import 'dart:convert';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'package:observatory/service_io.dart'; 9 import 'package:observatory/service_io.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
11 import 'test_helper.dart'; 11 import 'test_helper.dart';
12 12
13 Future<String> readResponse(HttpClientResponse response) { 13 Future<String> readResponse(HttpClientResponse response) {
14 var completer = new Completer(); 14 var completer = new Completer();
15 var contents = new StringBuffer(); 15 var contents = new StringBuffer();
16 response.transform(UTF8.decoder).listen((String data) { 16 response.transform(UTF8.decoder).listen((String data) {
17 contents.write(data); 17 contents.write(data);
18 }, onDone: () => completer.complete(contents.toString())); 18 }, onDone: () => completer.complete(contents.toString()));
19 return completer.future; 19 return completer.future;
20 } 20 }
21 21
22
22 var tests = [ 23 var tests = [
23 // Write a file with the \r character in the filename. 24 // Write a file with the \r character in the filename.
24 (VM vm) async { 25 (VM vm) async {
25 var fsId = 'test'; 26 var fsId = 'test';
26 var filePath = '/foo/b\rar.dart'; 27 var filePath = '/foo/b\rar.dart';
27 var filePathBase64 = BASE64.encode(UTF8.encode(filePath)); 28 var filePathBase64 = BASE64.encode(UTF8.encode(filePath));
28 var fileContents = [0, 1, 2, 3, 4, 5, 6, 255]; 29 var fileContents = [0, 1, 2, 3, 4, 5, 6, 255];
29 var fileContentsBase64 = BASE64.encode(fileContents); 30 var fileContentsBase64 = BASE64.encode(fileContents);
30 31
31 var result; 32 var result;
32 // Create DevFS. 33 // Create DevFS.
33 result = await vm.invokeRpcNoUpgrade('_createDevFS', {'fsName': fsId}); 34 result = await vm.invokeRpcNoUpgrade('_createDevFS', { 'fsName': fsId });
34 expect(result['type'], equals('FileSystem')); 35 expect(result['type'], equals('FileSystem'));
35 expect(result['name'], equals(fsId)); 36 expect(result['name'], equals(fsId));
36 expect(result['uri'], new isInstanceOf<String>()); 37 expect(result['uri'], new isInstanceOf<String>());
37 38
38 // Write the file by issuing an HTTP PUT. 39 // Write the file by issuing an HTTP PUT.
39 HttpClient client = new HttpClient(); 40 HttpClient client = new HttpClient();
40 HttpClientRequest request = 41 HttpClientRequest request =
41 await client.putUrl(Uri.parse(serviceHttpAddress)); 42 await client.putUrl(Uri.parse(serviceHttpAddress));
42 request.headers.add('dev_fs_name', fsId); 43 request.headers.add('dev_fs_name', fsId);
43 request.headers.add('dev_fs_path_b64', filePathBase64); 44 request.headers.add('dev_fs_path_b64', filePathBase64);
(...skipping 10 matching lines...) Expand all
54 request.write(GZIP.encode(fileContents)); 55 request.write(GZIP.encode(fileContents));
55 response = await request.close(); 56 response = await request.close();
56 responseBody = await readResponse(response); 57 responseBody = await readResponse(response);
57 result = JSON.decode(responseBody); 58 result = JSON.decode(responseBody);
58 Map error = result['error']['data']; 59 Map error = result['error']['data'];
59 expect(error, isNotNull); 60 expect(error, isNotNull);
60 expect(error['details'].contains("expects the 'path' parameter"), isTrue); 61 expect(error['details'].contains("expects the 'path' parameter"), isTrue);
61 62
62 // Write the file again but this time with the true file contents. 63 // Write the file again but this time with the true file contents.
63 client = new HttpClient(); 64 client = new HttpClient();
64 request = await client.putUrl(Uri.parse(serviceHttpAddress)); 65 request =
66 await client.putUrl(Uri.parse(serviceHttpAddress));
65 request.headers.add('dev_fs_name', fsId); 67 request.headers.add('dev_fs_name', fsId);
66 request.headers.add('dev_fs_path_b64', filePathBase64); 68 request.headers.add('dev_fs_path_b64', filePathBase64);
67 request.add(GZIP.encode(fileContents)); 69 request.add(GZIP.encode(fileContents));
68 response = await request.close(); 70 response = await request.close();
69 responseBody = await readResponse(response); 71 responseBody = await readResponse(response);
70 result = JSON.decode(responseBody); 72 result = JSON.decode(responseBody);
71 expect(result['result']['type'], equals('Success')); 73 expect(result['result']['type'], equals('Success'));
72 74
73 // Close the HTTP client. 75 // Close the HTTP client.
74 client.close(); 76 client.close();
75 77
76 // Read the file back. 78 // Read the file back.
77 result = await vm.invokeRpcNoUpgrade('_readDevFSFile', { 79 result = await vm.invokeRpcNoUpgrade('_readDevFSFile', {
78 'fsName': fsId, 80 'fsName': fsId,
79 'path': filePath, 81 'path': filePath,
80 }); 82 });
81 expect(result['type'], equals('FSFile')); 83 expect(result['type'], equals('FSFile'));
82 expect(result['fileContents'], equals(fileContentsBase64)); 84 expect(result['fileContents'], equals(fileContentsBase64));
83 85
84 // List all the files in the file system. 86 // List all the files in the file system.
85 result = await vm.invokeRpcNoUpgrade('_listDevFSFiles', { 87 result = await vm.invokeRpcNoUpgrade('_listDevFSFiles', {
86 'fsName': fsId, 88 'fsName': fsId,
87 }); 89 });
88 expect(result['type'], equals('FSFileList')); 90 expect(result['type'], equals('FSFileList'));
89 expect(result['files'].length, equals(1)); 91 expect(result['files'].length, equals(1));
90 expect(result['files'][0]['name'], equals(filePath)); 92 expect(result['files'][0]['name'], equals(filePath));
91 93
92 // Delete DevFS. 94 // Delete DevFS.
93 result = await vm.invokeRpcNoUpgrade('_deleteDevFS', { 95 result = await vm.invokeRpcNoUpgrade('_deleteDevFS', {
94 'fsName': fsId, 96 'fsName': fsId,
95 }); 97 });
96 expect(result['type'], equals('Success')); 98 expect(result['type'], equals('Success'));
97 }, 99 },
98 ]; 100 ];
99 101
100 main(args) async => runVMTests(args, tests); 102 main(args) async => runVMTests(args, tests);
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/dev_fs_http_put_test.dart ('k') | runtime/observatory/tests/service/dev_fs_spawn_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698