Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: runtime/observatory/tests/service/dev_fs_http_put_test.dart

Issue 2767533002: Revert "Fix observatory tests broken by running dartfmt." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--error_on_bad_type --error_on_bad_override 4 // VMOptions=--error_on_bad_type --error_on_bad_override
5 5
6 import 'dart:async'; 6 import 'dart:async';
7 import 'dart:convert'; 7 import 'dart:convert';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'package:observatory/service_io.dart'; 9 import 'package:observatory/service_io.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
11 import 'test_helper.dart'; 11 import 'test_helper.dart';
12 12
13 Future<String> readResponse(HttpClientResponse response) { 13 Future<String> readResponse(HttpClientResponse response) {
14 var completer = new Completer(); 14 var completer = new Completer();
15 var contents = new StringBuffer(); 15 var contents = new StringBuffer();
16 response.transform(UTF8.decoder).listen((String data) { 16 response.transform(UTF8.decoder).listen((String data) {
17 contents.write(data); 17 contents.write(data);
18 }, onDone: () => completer.complete(contents.toString())); 18 }, onDone: () => completer.complete(contents.toString()));
19 return completer.future; 19 return completer.future;
20 } 20 }
21 21
22
22 var tests = [ 23 var tests = [
23 // Write a file with the ? character in the filename. 24 // Write a file with the ? character in the filename.
24 (VM vm) async { 25 (VM vm) async {
25 var fsId = 'test'; 26 var fsId = 'test';
26 var filePath = '/foo/bar.dat'; 27 var filePath = '/foo/bar.dat';
27 var fileContents = [0, 1, 2, 3, 4, 5, 6, 255]; 28 var fileContents = [0, 1, 2, 3, 4, 5, 6, 255];
28 var fileContentsBase64 = BASE64.encode(fileContents); 29 var fileContentsBase64 = BASE64.encode(fileContents);
29 30
30 var result; 31 var result;
31 // Create DevFS. 32 // Create DevFS.
32 result = await vm.invokeRpcNoUpgrade('_createDevFS', {'fsName': fsId}); 33 result = await vm.invokeRpcNoUpgrade('_createDevFS', { 'fsName': fsId });
33 expect(result['type'], equals('FileSystem')); 34 expect(result['type'], equals('FileSystem'));
34 expect(result['name'], equals(fsId)); 35 expect(result['name'], equals(fsId));
35 expect(result['uri'], new isInstanceOf<String>()); 36 expect(result['uri'], new isInstanceOf<String>());
36 37
37 // Write the file by issuing an HTTP PUT. 38 // Write the file by issuing an HTTP PUT.
38 HttpClient client = new HttpClient(); 39 HttpClient client = new HttpClient();
39 HttpClientRequest request = 40 HttpClientRequest request =
40 await client.putUrl(Uri.parse(serviceHttpAddress)); 41 await client.putUrl(Uri.parse(serviceHttpAddress));
41 request.headers.add('dev_fs_name', fsId); 42 request.headers.add('dev_fs_name', fsId);
42 request.headers.add('dev_fs_path', filePath); 43 request.headers.add('dev_fs_path', filePath);
(...skipping 10 matching lines...) Expand all
53 request.write(GZIP.encode(fileContents)); 54 request.write(GZIP.encode(fileContents));
54 response = await request.close(); 55 response = await request.close();
55 responseBody = await readResponse(response); 56 responseBody = await readResponse(response);
56 result = JSON.decode(responseBody); 57 result = JSON.decode(responseBody);
57 Map error = result['error']['data']; 58 Map error = result['error']['data'];
58 expect(error, isNotNull); 59 expect(error, isNotNull);
59 expect(error['details'].contains("expects the 'path' parameter"), isTrue); 60 expect(error['details'].contains("expects the 'path' parameter"), isTrue);
60 61
61 // Write the file again but this time with the true file contents. 62 // Write the file again but this time with the true file contents.
62 client = new HttpClient(); 63 client = new HttpClient();
63 request = await client.putUrl(Uri.parse(serviceHttpAddress)); 64 request =
65 await client.putUrl(Uri.parse(serviceHttpAddress));
64 request.headers.add('dev_fs_name', fsId); 66 request.headers.add('dev_fs_name', fsId);
65 request.headers.add('dev_fs_path', filePath); 67 request.headers.add('dev_fs_path', filePath);
66 request.add(GZIP.encode(fileContents)); 68 request.add(GZIP.encode(fileContents));
67 response = await request.close(); 69 response = await request.close();
68 responseBody = await readResponse(response); 70 responseBody = await readResponse(response);
69 result = JSON.decode(responseBody); 71 result = JSON.decode(responseBody);
70 expect(result['result']['type'], equals('Success')); 72 expect(result['result']['type'], equals('Success'));
71 73
72 // Close the HTTP client. 74 // Close the HTTP client.
73 client.close(); 75 client.close();
74 76
75 // Read the file back. 77 // Read the file back.
76 result = await vm.invokeRpcNoUpgrade('_readDevFSFile', { 78 result = await vm.invokeRpcNoUpgrade('_readDevFSFile', {
77 'fsName': fsId, 79 'fsName': fsId,
78 'path': filePath, 80 'path': filePath,
79 }); 81 });
80 expect(result['type'], equals('FSFile')); 82 expect(result['type'], equals('FSFile'));
81 expect(result['fileContents'], equals(fileContentsBase64)); 83 expect(result['fileContents'], equals(fileContentsBase64));
82 84
83 // List all the files in the file system. 85 // List all the files in the file system.
84 result = await vm.invokeRpcNoUpgrade('_listDevFSFiles', { 86 result = await vm.invokeRpcNoUpgrade('_listDevFSFiles', {
85 'fsName': fsId, 87 'fsName': fsId,
86 }); 88 });
87 expect(result['type'], equals('FSFileList')); 89 expect(result['type'], equals('FSFileList'));
88 expect(result['files'].length, equals(1)); 90 expect(result['files'].length, equals(1));
89 expect(result['files'][0]['name'], equals(filePath)); 91 expect(result['files'][0]['name'], equals(filePath));
90 92
91 // Delete DevFS. 93 // Delete DevFS.
92 result = await vm.invokeRpcNoUpgrade('_deleteDevFS', { 94 result = await vm.invokeRpcNoUpgrade('_deleteDevFS', {
93 'fsName': fsId, 95 'fsName': fsId,
94 }); 96 });
95 expect(result['type'], equals('Success')); 97 expect(result['type'], equals('Success'));
96 }, 98 },
97 ]; 99 ];
98 100
99 main(args) async => runVMTests(args, tests); 101 main(args) async => runVMTests(args, tests);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698