Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 276753003: [Ozone-DRI] Move framebuffer initialization into the buffer (Closed)

Created:
6 years, 7 months ago by dnicoara
Modified:
6 years, 7 months ago
Reviewers:
rjkroege, spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

[Ozone-DRI] Move framebuffer initialization into the buffer Surface/buffer lifetimes are no longer bound by the controller. In addition, it is possible for multiple controllers to be linked against the same surface, making it impossible for a controller to know if the framebuffers need to be unregistered. Thus move framebuffer initialization into the buffer object. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269531

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -129 lines) Patch
M ui/ozone/platform/dri/dri_buffer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/ozone/platform/dri/dri_buffer.cc View 4 chunks +35 lines, -19 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_unittest.cc View 1 5 chunks +16 lines, -11 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller_unittest.cc View 3 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dnicoara
6 years, 7 months ago (2014-05-09 15:36:10 UTC) #1
rjkroege
lgtm
6 years, 7 months ago (2014-05-09 15:47:58 UTC) #2
spang
lgtm
6 years, 7 months ago (2014-05-09 16:16:26 UTC) #3
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 7 months ago (2014-05-09 16:43:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/276753003/20001
6 years, 7 months ago (2014-05-09 16:48:11 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 04:50:46 UTC) #6
Message was sent while issue was closed.
Change committed as 269531

Powered by Google App Engine
This is Rietveld 408576698