Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2767513002: Revert of DevTools: android shouldn't depend on devtools frontend (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 9 months ago
Reviewers:
dgozman, altimin
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: android shouldn't depend on devtools frontend (patchset #10 id:180001 of https://codereview.chromium.org/2755973003/ ) Reason for revert: crbug.com/703501 Original issue's description: > DevTools: android shouldn't depend on devtools frontend > > Should fix android CQ failures such as these: > https://codereview.chromium.org/2747553002/ > > BUG=none > > Review-Url: https://codereview.chromium.org/2755973003 > Cr-Commit-Position: refs/heads/master@{#458283} > Committed: https://chromium.googlesource.com/chromium/src/+/e88d836999be9b40cf7ee7eedcb4da6080cdeee2 TBR=dgozman@chromium.org,altimin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -46 lines) Patch
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/browser/devtools_frontend_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 3 chunks +1 line, -8 lines 0 comments Download
M headless/lib/browser/headless_devtools.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chenwilliam
Created Revert of DevTools: android shouldn't depend on devtools frontend
3 years, 9 months ago (2017-03-21 04:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767513002/1
3 years, 9 months ago (2017-03-21 04:23:08 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 04:23:10 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698