Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart

Issue 2767483002: Fix two bugs with async stack traces. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart
diff --git a/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart b/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart
index 1812693b87fda160be3e42c1ea85caa71b1c908f..1ba49c68e666dc23424f74d4f545d62d9ff5e5ee 100644
--- a/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart
+++ b/runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// VMOptions=--error_on_bad_type --error_on_bad_override
+// VMOptions=--optimization-counter-threshold=5 --error_on_bad_type --error_on_bad_override
import 'package:observatory/service_io.dart';
import 'package:observatory/models.dart' as M;
@@ -9,7 +10,7 @@ import 'package:unittest/unittest.dart';
import 'test_helper.dart';
import 'service_test_common.dart';
-const LINE_A = 29;
+const LINE_A = 36;
class Foo {
@@ -25,8 +26,14 @@ asyncThrower() async {
}
testeeMain() async {
+ // Trigger optimization via OSR.
+ var s = 0;
+ for (var i = 0; i < 100; i++) {
+ s += i;
+ }
+ print(s);
// No try ... catch.
- await asyncThrower();
+ await asyncThrower(); // LINE_A
}
var tests = [
« no previous file with comments | « no previous file | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698