Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2767483002: Fix two bugs with async stack traces. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix two bugs with async stack traces. 1. A crash when collecting an async stack trace with inlined frames on the stack. 2. A missing source position in an async stack trace. Fixes #29080. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ef7487a7a8b8604401cfafabe6bd2555b6847f17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -44 lines) Patch
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 6 chunks +59 lines, -37 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/await_exceptions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/await_future_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/await_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
3 years, 9 months ago (2017-03-21 01:13:01 UTC) #2
Cutch
lgtm
3 years, 9 months ago (2017-03-21 13:59:17 UTC) #4
Florian Schneider
3 years, 9 months ago (2017-03-21 16:31:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef7487a7a8b8604401cfafabe6bd2555b6847f17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698