dashboard/dashboard/elements/test-picker-test.html - Issue 2767433002: Start using /list_tests to populate subtest menus in test-picker

Side by Side Diff: dashboard/dashboard/elements/test-picker-test.html

Issue 2767433002: Start using /list_tests to populate subtest menus in test-picker (Closed)

Patch Set: done Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2015 The Chromium Authors. All rights reserved.	3 Copyright 2015 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/dashboard/elements/test-picker.html">	8 <link rel="import" href="/dashboard/elements/test-picker.html">

9 <link rel="import" href="/dashboard/static/testing_common.html">	9 <link rel="import" href="/dashboard/static/testing_common.html">

10	10

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
103 // and deprecated.	103 // and deprecated.

104 var expectedSuites = ['blink_perf', 'dromaeo', 'endure'];	104 var expectedSuites = ['blink_perf', 'dromaeo', 'endure'];

105 var actualSuites = [];	105 var actualSuites = [];

106 for (var i = 0; i < suiteItems.length; i++) {	106 for (var i = 0; i < suiteItems.length; i++) {

107 actualSuites.push(suiteItems[i].name);	107 actualSuites.push(suiteItems[i].name);

108 }	108 }

109 assert.deepEqual(actualSuites, expectedSuites);	109 assert.deepEqual(actualSuites, expectedSuites);

110 }, testOptions);	110 }, testOptions);

111	111

112 test('fullPathRetained', function() {	112 test('fullPathRetained', function() {

113 testing_common.addXhrMock('*', JSON.stringify(MOCK_RESPONSE));

114 let testPicker = document.createElement('test-picker');	113 let testPicker = document.createElement('test-picker');

115 testPicker.testSuites = {	114 testPicker.testSuites = {

116 'endure': {	115 'endure': {

117 'mas': {'Chromium': {'mac': false, 'win7': true}},	116 'mas': {'Chromium': {'mac': false, 'win7': true}},

118 'dep': true	117 'dep': true

119 },	118 },

120 'dromaeo': {	119 'dromaeo': {

121 'mas': {'Chromium': {'mac': false, 'win7': false}}	120 'mas': {'Chromium': {'mac': false, 'win7': false}}

122 },	121 },

123 'blink_perf': {	122 'blink_perf': {

124 'mas': {'Chromium': {'mac': false, 'win7': false}},	123 'mas': {'Chromium': {'mac': false, 'win7': false}},

125 'mon': ['select-multiple-add/select-multiple-add.html']	124 'mon': ['select-multiple-add/select-multiple-add.html']

126 }	125 }

127 };	126 };

	127 testPicker.subtests.prepopulate({

	128 'Chromium/mac/blink_perf': ['Chromium/mac/blink_perf/textarea-edit'],

	129 'Chromium/mac/blink_perf/textarea-edit': [

	130 'Chromium/mac/blink_perf/textarea_edit.html']

	131 });

128	132

129 let suiteMenu = testPicker.getSelectionMenu(0);	133 let suiteMenu = testPicker.getSelectionMenu(0);

130 suiteMenu.selectedItem = suiteMenu.items[0];	134 suiteMenu.selectedItem = suiteMenu.items[0];

131	135

132 let botMenu = testPicker.getSelectionMenu(1);	136 let botMenu = testPicker.getSelectionMenu(1);

133 botMenu.selectedItem = botMenu.items[0];	137 // Pick the second bot menu item because the first is the master.

	138 botMenu.selectedItem = botMenu.items[1];
	eakuefner 2017/04/13 23:26:03 The problem with this is, mutating selectedItem li The problem with this is, mutating selectedItem like this causes Polymer to call onDropdownSelect which then calls updateSubtestMenus, which is asynchronous and causes the benchmark menu to be populated. Hence, below when we say let benchmarkMenu = testPicker.getSelectionMenu(2), it doesn't return the would-be second menu. Previously, this didn't matter, because the XHR mocks worked synchronously. I'm not sure what the best way to do this, because we don't have access to the promise returned by updateSubtestMenus so we can't await it. We could call updateSubtestMenus explicitly here, in which case we would duplicate effort but be able to explicitly await that call, but I'm also wondering if this is a discussion we should punt, at the cost of this bit of test coverage. sullivan 2017/04/14 00:37:30 2 things: 1) I think it's okay to expicitly call Show quoted text On 2017/04/13 23:26:03, eakuefner wrote: > The problem with this is, mutating selectedItem like this causes Polymer to call > onDropdownSelect which then calls updateSubtestMenus, which is asynchronous and > causes the benchmark menu to be populated. Hence, below when we say let > benchmarkMenu = testPicker.getSelectionMenu(2), it doesn't return the would-be > second menu. Previously, this didn't matter, because the XHR mocks worked > synchronously. > > I'm not sure what the best way to do this, because we don't have access to the > promise returned by updateSubtestMenus so we can't await it. We could call > updateSubtestMenus explicitly here, in which case we would duplicate effort but > be able to explicitly await that call, but I'm also wondering if this is a > discussion we should punt, at the cost of this bit of test coverage. 2 things: 1) I think it's okay to expicitly call updateSubtestMenus in order to keep this test passing, because this is a feature that has broken in the past. 2) Since you re-implemented to have a memoization pattern, shouldn't there be a simple test that uses it as intended? eakuefner 2017/04/14 17:34:26 Done. Show quoted text On 2017/04/14 at 00:37:30, sullivan wrote: > On 2017/04/13 23:26:03, eakuefner wrote: > > The problem with this is, mutating selectedItem like this causes Polymer to call > > onDropdownSelect which then calls updateSubtestMenus, which is asynchronous and > > causes the benchmark menu to be populated. Hence, below when we say let > > benchmarkMenu = testPicker.getSelectionMenu(2), it doesn't return the would-be > > second menu. Previously, this didn't matter, because the XHR mocks worked > > synchronously. > > > > I'm not sure what the best way to do this, because we don't have access to the > > promise returned by updateSubtestMenus so we can't await it. We could call > > updateSubtestMenus explicitly here, in which case we would duplicate effort but > > be able to explicitly await that call, but I'm also wondering if this is a > > discussion we should punt, at the cost of this bit of test coverage. > > 2 things: > > 1) I think it's okay to expicitly call updateSubtestMenus in order to keep this test passing, because this is a feature that has broken in the past. Done. Show quoted text > 2) Since you re-implemented to have a memoization pattern, shouldn't there be a simple test that uses it as intended? Added a test that uses an XHR mock to test fetching behavior, a test that tests prepopulate, and finally a smoke test that ensures that Subtests stores promises.
134	139

135 let benchmarkMenu = testPicker.getSelectionMenu(2);	140 let benchmarkMenu = testPicker.getSelectionMenu(2);

136 let expectedBenchmark = benchmarkMenu.items[0].name;	141 let expectedBenchmark = benchmarkMenu.items[0].name;

137 benchmarkMenu.selectedItem = benchmarkMenu.items[0];	142 benchmarkMenu.selectedItem = benchmarkMenu.items[0];

138	143

139 let metricMenu = testPicker.getSelectionMenu(3);	144 let metricMenu = testPicker.getSelectionMenu(3);

140 let expectedMetric = metricMenu.items[0].name;	145 let expectedMetric = metricMenu.items[0].name;

141 metricMenu.selectedItem = metricMenu.items[0];	146 metricMenu.selectedItem = metricMenu.items[0];

142	147

143 // Now pick a new bot	148 // Now pick a new bot

144 botMenu.selectedItem = botMenu.items[1];	149 botMenu.selectedItem = botMenu.items[1];

145	150

146 assert.deepEqual(benchmarkMenu.selectedItem.name, expectedBenchmark);	151 assert.deepEqual(benchmarkMenu.selectedItem.name, expectedBenchmark);

147 assert.deepEqual(metricMenu.selectedItem.name, expectedMetric);	152 assert.deepEqual(metricMenu.selectedItem.name, expectedMetric);

148 }, testOptions);	153 }, testOptions);

149	154

150 test('getCurrentSelectionReturnsNullIfInvalid', async function() {	155 test('getCurrentSelectionReturnsUndefinedIfInvalid', async function() {

151 testing_common.addXhrMock('*', JSON.stringify(MOCK_RESPONSE));

152 let testPicker = document.createElement('test-picker');	156 let testPicker = document.createElement('test-picker');

153 testPicker.testSuites = {	157 testPicker.testSuites = {

154 'endure': {	158 'endure': {

155 'mas': {'Chromium': {'mac': false, 'win7': true}},	159 'mas': {'Chromium': {'mac': false, 'win7': true}},

156 'dep': true	160 'dep': true

157 },	161 },

158 'dromaeo': {	162 'dromaeo': {

159 'mas': {'Chromium': {'mac': false, 'win7': false}}	163 'mas': {'Chromium': {'mac': false, 'win7': false}}

160 },	164 },

161 'blink_perf': {	165 'blink_perf': {

162 'mas': {'Chromium': {'mac': false, 'win7': false}},	166 'mas': {'Chromium': {'mac': false, 'win7': false}},

163 'mon': ['select-multiple-add/select-multiple-add.html']	167 'mon': ['select-multiple-add/select-multiple-add.html']

164 }	168 }

165 };	169 };

166	170

167 let suiteMenu = testPicker.getSelectionMenu(0);	171 let suiteMenu = testPicker.getSelectionMenu(0);

168 suiteMenu.selectedItem = suiteMenu.items[0];	172 suiteMenu.selectedItem = suiteMenu.items[0];

169	173

170 let botMenu = testPicker.getSelectionMenu(1);	174 let botMenu = testPicker.getSelectionMenu(1);

171 botMenu.selectedItem = botMenu.items[0];	175 botMenu.selectedItem = botMenu.items[0];

172	176

173 assert.isNull(await testPicker.getCurrentSelection());	177 assert.isUndefined(await testPicker.getCurrentSelection());

174 testing_common.clearXhrMock();

175 });	178 });

176 });	179 });

177 </script>	180 </script>

OLD	NEW

« dashboard/dashboard/elements/test-picker.html ('K') | « dashboard/dashboard/elements/test-picker.html ('k') | no next file » | no next file with comments »