src/hydrogen.h - Issue 27674002: Inline number to string conversion for string addition into BinaryOp(Stub).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.h

Issue 27674002: Inline number to string conversion for string addition into BinaryOp(Stub). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Avoid the round-trip via StringAddStub when invoking the STRING_ADD_* builtins in the fallback case. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.h

diff --git a/src/hydrogen.h b/src/hydrogen.h

index bd28ba1b74d55da9df2dd5c11cc615a6c4ba4f0b..910bea232aa51a73c6156074427ce1052a643abd 100644

--- a/src/hydrogen.h

+++ b/src/hydrogen.h

@@ -1234,14 +1234,8 @@ class HGraphBuilder {

ElementsKind to_kind,

bool is_jsarray);

- // Do lookup in the number string cache. If the object is not found

- // in the cache, the false branch of the continuation is taken;

- // otherwise the true branch is taken and the returned value contains

- // the cache value for the object. The returned value must NOT be used

- // on the false branch.

- HValue* BuildLookupNumberStringCache(HValue* object,

- HIfContinuation* continuation);

- HValue* BuildNumberToString(HValue* number);

+ HValue* BuildNumberToString(HValue* object,

+ Handle<Type> type);

rossberg 2013/10/21 12:06:17 Nit: should fit on previous line

Benedikt Meurer 2013/10/21 12:09:43 Done.

HInstruction* BuildUncheckedMonomorphicElementAccess(

HValue* checked_object,

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/hydrogen.cc » ('j') | src/hydrogen.cc » ('J')