Add Digital Asset Links verification for postMessage API

chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc

Index: chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
diff --git a/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc b/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7056ee7a4209d4c83bf53c9d4707a7cca21e6bb4
--- /dev/null
+++ b/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
@@ -0,0 +1,137 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/digital_asset_links/digital_asset_links_handler.h"
+
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/json/json_reader.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/values.h"
+#include "components/safe_json/testing_json_parser.h"
+#include "content/public/test/test_browser_thread.h"
+#include "net/base/net_errors.h"
+#include "net/http/http_status_code.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class DigitalAssetLinksHandlerTest : public ::testing::Test {
+ public:
+  DigitalAssetLinksHandlerTest()
+      : num_invocations_(0),
+        response_(nullptr),
+        io_thread_(content::BrowserThread::IO, &message_loop_) {}
+
+  void OnRelationshipCheckComplete(
+      std::unique_ptr<base::DictionaryValue> response) {
+    ++num_invocations_;
+    response_ = std::move(response);
+  }
+
+ protected:
+  void SetUp() override { num_invocations_ = 0; }
+
+  void SendResponse(net::Error error, int response_code, bool linked) {
+    net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
+    ASSERT_TRUE(fetcher);
+    fetcher->set_status(net::URLRequestStatus::FromError(error));
+    fetcher->set_response_code(response_code);
+    if (error == net::OK && response_code == net::HTTP_OK && linked) {
+      fetcher->SetResponseString(
+          R"({
+            "linked":  true ,
+            "maxAge": "40.188652381s"
+          })");
+    } else if (error == net::OK && response_code == net::HTTP_OK) {
+      fetcher->SetResponseString(
+          R"({
+            "linked":  false ,
+            "maxAge": "40.188652381s"
+          })");
+    } else if (error == net::OK && response_code == net::HTTP_BAD_REQUEST) {
+      fetcher->SetResponseString(
+          R"({
+            "code":  400 ,
+            "message": "Invalid statement query received."
+            "status": "INVALID_ARGUMENT"
+          })");
+    } else {
+      fetcher->SetResponseString("");
+    }
+    fetcher->delegate()->OnURLFetchComplete(fetcher);
+    base::RunLoop().RunUntilIdle();
+  }
+
+  int num_invocations_;
+  std::unique_ptr<base::DictionaryValue> response_;
+
+ private:
+  base::MessageLoop message_loop_;
+  safe_json::TestingJsonParser::ScopedFactoryOverride factory_override_;
+  content::TestBrowserThread io_thread_;
+  net::TestURLFetcherFactory url_fetcher_factory_;
+  DISALLOW_COPY_AND_ASSIGN(DigitalAssetLinksHandlerTest);

[nyquist, 2017/04/27 04:38:25]

Nit: I think we usually have an empty line before this one.

[Yusuf, 2017/04/27 17:38:56]

Done.

+};
+
+TEST_F(DigitalAssetLinksHandlerTest, PositiveResponse) {

[nyquist, 2017/04/27 04:38:25]

Nit: I think I'd end the anonymous namespace right before this method, but wrap
the whole file (like before) in the digital_asset_links namespace.
That way you don't have to prefix the class-under-test with the namespace.

[Yusuf, 2017/04/27 17:38:56]

Done.

+  digital_asset_links::DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_OK, true);
+
+  bool verified = false;
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_TRUE(response_);
+  response_->GetBoolean(
+      digital_asset_links::kDigitalAssetLinksCheckResponseKeyLinked, &verified);
+  EXPECT_TRUE(verified);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, NegativeResponse) {
+  digital_asset_links::DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_OK, false);
+
+  bool verified = false;
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_TRUE(response_);
+  response_->GetBoolean(
+      digital_asset_links::kDigitalAssetLinksCheckResponseKeyLinked, &verified);
+  EXPECT_FALSE(verified);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, BadRequest) {
+  digital_asset_links::DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_BAD_REQUEST, true);
+
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_FALSE(response_);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, NetworkError) {
+  digital_asset_links::DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::ERR_ABORTED, net::HTTP_OK, true);
+
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_FALSE(response_);
+}
+}  // namespace