Add Digital Asset Links verification for postMessage API

chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc

Index: chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
diff --git a/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc b/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f1623d35256f6135dd4ec6e0f2e2aa1d7f5f81fa
--- /dev/null
+++ b/chrome/browser/android/digital_asset_links/digital_asset_links_handler_unittest.cc
@@ -0,0 +1,132 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/digital_asset_links/digital_asset_links_handler.h"

[nyquist, 2017/04/19 06:35:57]

Nit: Empty line after this?

[Yusuf, 2017/04/26 00:51:37]

Done.

+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/json/json_reader.h"
+#include "base/message_loop/message_loop.h"
+#include "base/values.h"
+#include "content/public/test/test_browser_thread.h"
+#include "net/base/net_errors.h"
+#include "net/http/http_status_code.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace digital_asset_links {
+
+class DigitalAssetLinksHandlerTest : public ::testing::Test {

[nyquist, 2017/04/19 06:35:57]

Nit: Should this class be in an anonymous namespace?

[Yusuf, 2017/04/26 00:51:37]

Done.

+ public:
+  DigitalAssetLinksHandlerTest()
+      : io_thread_(content::BrowserThread::IO, &message_loop_),
+        num_invocations_(0),
+        response_(nullptr) {}
+
+  ~DigitalAssetLinksHandlerTest() override {}

[nyquist, 2017/04/19 06:35:57]

Nit: = default?

[Yusuf, 2017/04/26 00:51:37]

Done.

+
+  void OnRelationshipCheckComplete(
+      std::unique_ptr<base::DictionaryValue> response) {
+    ++num_invocations_;
+    response_ = std::move(response);
+  }
+
+ protected:
+  void SetUp() override { num_invocations_ = 0; }
+
+  void SendResponse(net::Error error, int response_code, bool linked) {
+    net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
+    ASSERT_TRUE(fetcher);
+    fetcher->set_status(net::URLRequestStatus::FromError(error));
+    fetcher->set_response_code(response_code);
+    if (error == net::OK && response_code == net::HTTP_OK && linked) {
+      fetcher->SetResponseString(
+          R"({
+            "linked":  true ,
+            "maxAge": "40.188652381s"
+          })");
+    } else if (error == net::OK && response_code == net::HTTP_OK) {
+      fetcher->SetResponseString(
+          R"({
+            "linked":  false ,
+            "maxAge": "40.188652381s"
+          })");
+    } else if (error == net::OK && response_code == net::HTTP_BAD_REQUEST) {
+      fetcher->SetResponseString(
+          R"({
+            "code":  400 ,
+            "message": "Invalid statement query received."
+            "status": "INVALID_ARGUMENT"
+          })");
+    } else {
+      fetcher->SetResponseString("");
+    }
+    fetcher->delegate()->OnURLFetchComplete(fetcher);
+  }
+
+  base::MessageLoop message_loop_;

[nyquist, 2017/04/19 06:35:57]

Nit: Could some of these be private?

[Yusuf, 2017/04/26 00:51:37]

Done.

+  content::TestBrowserThread io_thread_;
+  net::TestURLFetcherFactory url_fetcher_factory_;
+
+  int num_invocations_;
+  std::unique_ptr<base::DictionaryValue> response_;
+};

[nyquist, 2017/04/19 06:35:57]

Nit:
 private:
  DISALLOW_COPY_AND_ASSIGN(DigitalAssetLinksHandlerTest);

[Yusuf, 2017/04/26 00:51:37]

Done.

+
+TEST_F(DigitalAssetLinksHandlerTest, ValidResponse) {
+  DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_OK, true);
+
+  bool verified = false;
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_TRUE(response_);
+  response_->GetBoolean(
+      digital_asset_links::kDigitalAssetLinksCheckResponseKeyLinked, &verified);
+  EXPECT_TRUE(verified);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, InvalidResponse) {

[nyquist, 2017/04/19 06:35:57]

Nit: Is the response invalid, or is it just that the result was that there was
no link verified?

[Yusuf, 2017/04/26 00:51:37]

Renamed to Positive/NegativeResponse.

+  DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_OK, false);
+
+  bool verified = false;
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_TRUE(response_);
+  response_->GetBoolean(
+      digital_asset_links::kDigitalAssetLinksCheckResponseKeyLinked, &verified);
+  EXPECT_FALSE(verified);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, BadRequest) {
+  DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::OK, net::HTTP_BAD_REQUEST, true);
+
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_FALSE(response_);
+}
+
+TEST_F(DigitalAssetLinksHandlerTest, NetworkError) {
+  DigitalAssetLinksHandler handler(nullptr);
+  handler.CheckDigitalAssetLinkRelationship(
+      base::Bind(&DigitalAssetLinksHandlerTest::OnRelationshipCheckComplete,
+                 base::Unretained(this)),
+      "", "", "", "");
+  SendResponse(net::ERR_ABORTED, net::HTTP_OK, true);
+
+  EXPECT_EQ(1, num_invocations_);
+  EXPECT_FALSE(response_);
+}
+}  // namespace digital_asset_links