Source/core/xml/parser/XMLDocumentParser.h - Issue 276733002: Convert XMLDocumentParser code to Use more reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.h

Issue 276733002: Convert XMLDocumentParser code to Use more reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/parser/XMLDocumentParser.h

diff --git a/Source/core/xml/parser/XMLDocumentParser.h b/Source/core/xml/parser/XMLDocumentParser.h

index 294c02d8cceea9b4a32603c05d1176b055df5002..0146716571ccfbf9ed21ffcbcdce3d506228bd6b 100644

--- a/Source/core/xml/parser/XMLDocumentParser.h

+++ b/Source/core/xml/parser/XMLDocumentParser.h

@@ -66,7 +66,7 @@ class Text;

class XMLDocumentParser FINAL : public ScriptableDocumentParser, public ResourceClient {

WTF_MAKE_FAST_ALLOCATED;

public:

- static PassRefPtr<XMLDocumentParser> create(Document* document, FrameView* view)

+ static PassRefPtr<XMLDocumentParser> create(Document& document, FrameView* view)

{

return adoptRef(new XMLDocumentParser(document, view));

}

@@ -101,7 +101,7 @@ class Text;

};

private:

- XMLDocumentParser(Document*, FrameView* = 0);

+ XMLDocumentParser(Document&, FrameView* = 0);

Inactive 2014/05/08 19:45:42 nit: explicit

maheshkk 2014/05/08 20:02:32 Done.

XMLDocumentParser(DocumentFragment*, Element*, ParserContentPolicy);

// From DocumentParser

« Source/core/inspector/DOMPatchSupport.cpp ('K') | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | no next file with comments »