 Chromium Code Reviews
 Chromium Code Reviews Issue 276733002:
  Convert XMLDocumentParser code to Use more reference  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 276733002:
  Convert XMLDocumentParser code to Use more reference  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. | 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. | 
| 3 * | 3 * | 
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without | 
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions | 
| 6 * are met: | 6 * are met: | 
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright | 
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. | 
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright | 
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the | 
| (...skipping 18 matching lines...) Expand all Loading... | |
| 29 | 29 | 
| 30 #include "wtf/Assertions.h" | 30 #include "wtf/Assertions.h" | 
| 31 | 31 | 
| 32 namespace WebCore { | 32 namespace WebCore { | 
| 33 | 33 | 
| 34 DocumentParser::DocumentParser(Document* document) | 34 DocumentParser::DocumentParser(Document* document) | 
| 35 : m_state(ParsingState) | 35 : m_state(ParsingState) | 
| 36 , m_documentWasLoadedAsPartOfNavigation(false) | 36 , m_documentWasLoadedAsPartOfNavigation(false) | 
| 37 , m_document(document) | 37 , m_document(document) | 
| 38 { | 38 { | 
| 39 ASSERT(document); | |
| 
Inactive
2014/05/08 19:45:42
Why did you remove this assertion? (you did not ma
 
maheshkk
2014/05/08 20:02:32
I forgot to undo this change. I originally moved D
 | |
| 40 } | 39 } | 
| 41 | 40 | 
| 42 DocumentParser::~DocumentParser() | 41 DocumentParser::~DocumentParser() | 
| 43 { | 42 { | 
| 44 // Document is expected to call detach() before releasing its ref. | 43 // Document is expected to call detach() before releasing its ref. | 
| 45 // This ASSERT is slightly awkward for parsers with a fragment case | 44 // This ASSERT is slightly awkward for parsers with a fragment case | 
| 46 // as there is no Document to release the ref. | 45 // as there is no Document to release the ref. | 
| 47 ASSERT(!m_document); | 46 ASSERT(!m_document); | 
| 48 } | 47 } | 
| 49 | 48 | 
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 82 void DocumentParser::suspendScheduledTasks() | 81 void DocumentParser::suspendScheduledTasks() | 
| 83 { | 82 { | 
| 84 } | 83 } | 
| 85 | 84 | 
| 86 void DocumentParser::resumeScheduledTasks() | 85 void DocumentParser::resumeScheduledTasks() | 
| 87 { | 86 { | 
| 88 } | 87 } | 
| 89 | 88 | 
| 90 }; | 89 }; | 
| 91 | 90 | 
| OLD | NEW |