test/inspector/protocol-test.js - Issue 2767323002: [inspector] better isArrayLike for injected-script-source.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/inspector/protocol-test.js

Issue 2767323002: [inspector] better isArrayLike for injected-script-source.js (Closed)

Patch Set: length on array should be own property Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/inspector/v8-injected-script-host.cc ('K') | « src/inspector/v8-injected-script-host.cc ('k') | test/inspector/runtime/evaluate-with-generate-preview.js » ('j') | test/inspector/runtime/evaluate-with-generate-preview.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/inspector/protocol-test.js

diff --git a/test/inspector/protocol-test.js b/test/inspector/protocol-test.js

index a948533eb5f67459eb869858bc45c83945768ee8..84a158868c6b2ba7cf983c85661c610c55559abd 100644

--- a/test/inspector/protocol-test.js

+++ b/test/inspector/protocol-test.js

@@ -344,6 +344,7 @@ InspectorTest.makeContextDirty = function(debug) {

if (debug) {

InspectorTest.log('WARNING: InspectorTest.makeContextDirty with debug flag for debugging only and should not be landed.');

InspectorTest.log('WARNING: run test with --expose-inspector-scripts flag to get more details.');

+ InspectorTest.log('WARNING: you can additionally comment \'input_text = rjsmin.jsmin(input_text)\' line in xxd.py to get unminified injected-script-source.js.');

dgozman 2017/03/23 21:10:20 Let's not be too specific (or it will be outdated)

kozy 2017/03/24 00:40:37 Done.

InspectorTest.setupScriptMap();

Protocol.Debugger.enable();

Protocol.Debugger.onPaused(message => {