Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(324)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/inspector/runtime/evaluate-with-generate-preview-expected.txt
Issue
2767323002
:
[inspector] better isArrayLike for injected-script-source.js (Closed)
Patch Set: addressed comments
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/inspector/injected-script-source.js
src/inspector/injected_script_externs.js
src/inspector/v8-injected-script-host.h
src/inspector/v8-injected-script-host.cc
test/inspector/protocol-test.js
test/inspector/runtime/evaluate-with-generate-preview.js
test/inspector/runtime/evaluate-with-generate-preview-expected.txt
View unified diff
|
Download patch
« no previous file with comments
|
« test/inspector/runtime/evaluate-with-generate-preview.js
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 Tests that Runtime.evaluate will generate correct previews.
1 Tests that Runtime.evaluate will generate correct previews.
2
2
3 Running test: testObjectPropertiesPreview
3 Running test: testObjectPropertiesPreview
4 {
4 {
5 description : Object
5 description : Object
6 overflow : false
6 overflow : false
7 properties : [
7 properties : [
8 [0] : {
8 [0] : {
9 name : p1
9 name : p1
10 type : object
10 type : object
(...skipping
809
matching lines...)
Expand 10 before
|
Expand all
|
Expand 10 after
Loading...
820 overflow : false
820 overflow : false
821 properties : [
821 properties : [
822 [0] : {
822 [0] : {
823 name : propNotNamedProto
823 name : propNotNamedProto
824 type : number
824 type : number
825 value : NaN
825 value : NaN
826 }
826 }
827 ]
827 ]
828 type : object
828 type : object
829 }
829 }
830
831
Running test: testObjWithArrayAsProto
832
{
833
description : Array
834
overflow : false
835
properties : [
836
]
837
type : object
838
}
OLD
NEW
« no previous file with comments
|
« test/inspector/runtime/evaluate-with-generate-preview.js
('k') |
no next file »
|
no next file with comments »
Issue 2767323002: [inspector] better isArrayLike for injected-script-source.js (Closed)
Created 3 years, 9 months ago by kozy
Modified 3 years, 9 months ago
Reviewers: dgozman, luoe
Base URL:
Comments: 10
This is Rietveld
408576698
Chromium Code Reviews
Issue 2767323002:
[inspector] better isArrayLike for injected-script-source.js (Closed)
