OLD | NEW |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/macros.h" | 5 #include "base/macros.h" |
6 #include "base/message_loop/message_loop.h" | 6 #include "base/message_loop/message_loop.h" |
7 #include "base/run_loop.h" | 7 #include "base/run_loop.h" |
| 8 #include "base/strings/string_number_conversions.h" |
8 #include "base/strings/stringprintf.h" | 9 #include "base/strings/stringprintf.h" |
9 #include "chromeos/dbus/dbus_thread_manager.h" | 10 #include "chromeos/dbus/dbus_thread_manager.h" |
10 #include "chromeos/dbus/shill_device_client.h" | 11 #include "chromeos/dbus/shill_device_client.h" |
11 #include "chromeos/dbus/shill_profile_client.h" | 12 #include "chromeos/dbus/shill_profile_client.h" |
12 #include "chromeos/dbus/shill_service_client.h" | 13 #include "chromeos/dbus/shill_service_client.h" |
13 #include "chromeos/login/login_state.h" | 14 #include "chromeos/login/login_state.h" |
14 #include "chromeos/network/managed_network_configuration_handler.h" | 15 #include "chromeos/network/managed_network_configuration_handler.h" |
15 #include "chromeos/network/network_handler.h" | 16 #include "chromeos/network/network_handler.h" |
16 #include "chromeos/network/network_state.h" | 17 #include "chromeos/network/network_state.h" |
17 #include "chromeos/network/network_state_handler.h" | 18 #include "chromeos/network/network_state_handler.h" |
| 19 #include "components/onc/onc_constants.h" |
18 #include "extensions/browser/api/networking_private/networking_private_api.h" | 20 #include "extensions/browser/api/networking_private/networking_private_api.h" |
19 #include "extensions/browser/api_unittest.h" | 21 #include "extensions/browser/api_unittest.h" |
20 #include "extensions/common/value_builder.h" | 22 #include "extensions/common/value_builder.h" |
21 #include "third_party/cros_system_api/dbus/shill/dbus-constants.h" | 23 #include "third_party/cros_system_api/dbus/shill/dbus-constants.h" |
22 | 24 |
23 namespace extensions { | 25 namespace extensions { |
24 | 26 |
25 namespace { | 27 namespace { |
26 | 28 |
27 const char kUserHash[] = "test_user_hash"; | 29 const char kUserHash[] = "test_user_hash"; |
28 const char kUserProfilePath[] = "/network_profile/user/shill"; | 30 const char kUserProfilePath[] = "/network_profile/user/shill"; |
29 | 31 |
30 const char kWifiDevicePath[] = "/device/stub_wifi_device"; | 32 const char kWifiDevicePath[] = "/device/stub_wifi_device"; |
31 | 33 |
32 const char kSharedWifiServicePath[] = "/service/shared_wifi"; | 34 const char kSharedWifiServicePath[] = "/service/shared_wifi"; |
33 const char kSharedWifiGuid[] = "shared_wifi_guid"; | 35 const char kSharedWifiGuid[] = "shared_wifi_guid"; |
34 const char kSharedWifiName[] = "shared_wifi"; | 36 const char kSharedWifiName[] = "shared_wifi"; |
35 | 37 |
36 const char kPrivateWifiServicePath[] = "/service/private_wifi"; | 38 const char kPrivateWifiServicePath[] = "/service/private_wifi"; |
37 const char kPrivateWifiGuid[] = "private_wifi_guid"; | 39 const char kPrivateWifiGuid[] = "private_wifi_guid"; |
38 const char kPrivateWifiName[] = "private_wifi"; | 40 const char kPrivateWifiName[] = "private_wifi"; |
39 | 41 |
| 42 const char kManagedUserWifiGuid[] = "managed_user_wifi_guid"; |
| 43 const char kManagedUserWifiSsid[] = "managed_user_wifi"; |
| 44 |
| 45 const char kManagedDeviceWifiGuid[] = "managed_device_wifi_guid"; |
| 46 const char kManagedDeviceWifiSsid[] = "managed_device_wifi"; |
| 47 |
40 } // namespace | 48 } // namespace |
41 | 49 |
42 class NetworkingPrivateApiTest : public ApiUnitTest { | 50 class NetworkingPrivateApiTest : public ApiUnitTest { |
43 public: | 51 public: |
44 NetworkingPrivateApiTest() {} | 52 NetworkingPrivateApiTest() {} |
45 ~NetworkingPrivateApiTest() override {} | 53 ~NetworkingPrivateApiTest() override {} |
46 | 54 |
47 void SetUp() override { | 55 void SetUp() override { |
48 ApiUnitTest::SetUp(); | 56 ApiUnitTest::SetUp(); |
49 | 57 |
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
121 shill::kProfileProperty, | 129 shill::kProfileProperty, |
122 base::Value(kUserProfilePath)); | 130 base::Value(kUserProfilePath)); |
123 profile_test_->AddService(kUserProfilePath, kPrivateWifiServicePath); | 131 profile_test_->AddService(kUserProfilePath, kPrivateWifiServicePath); |
124 } | 132 } |
125 | 133 |
126 void SetUpNetworkPolicy() { | 134 void SetUpNetworkPolicy() { |
127 chromeos::ManagedNetworkConfigurationHandler* config_handler = | 135 chromeos::ManagedNetworkConfigurationHandler* config_handler = |
128 chromeos::NetworkHandler::Get() | 136 chromeos::NetworkHandler::Get() |
129 ->managed_network_configuration_handler(); | 137 ->managed_network_configuration_handler(); |
130 | 138 |
| 139 const std::string user_policy_ssid = kManagedUserWifiSsid; |
| 140 std::unique_ptr<base::ListValue> user_policy_onc = |
| 141 ListBuilder() |
| 142 .Append(DictionaryBuilder() |
| 143 .Set("GUID", kManagedUserWifiGuid) |
| 144 .Set("Type", "WiFi") |
| 145 .Set("WiFi", |
| 146 DictionaryBuilder() |
| 147 .Set("Passphrase", "fake") |
| 148 .Set("SSID", user_policy_ssid) |
| 149 .Set("HexSSID", |
| 150 base::HexEncode(user_policy_ssid.c_str(), |
| 151 user_policy_ssid.size())) |
| 152 .Set("Security", "WPA-PSK") |
| 153 .Build()) |
| 154 .Build()) |
| 155 .Build(); |
| 156 |
131 config_handler->SetPolicy(::onc::ONC_SOURCE_USER_POLICY, kUserHash, | 157 config_handler->SetPolicy(::onc::ONC_SOURCE_USER_POLICY, kUserHash, |
132 base::ListValue(), base::DictionaryValue()); | 158 *user_policy_onc, base::DictionaryValue()); |
133 | 159 |
| 160 const std::string device_policy_ssid = kManagedDeviceWifiSsid; |
| 161 std::unique_ptr<base::ListValue> device_policy_onc = |
| 162 ListBuilder() |
| 163 .Append(DictionaryBuilder() |
| 164 .Set("GUID", kManagedDeviceWifiGuid) |
| 165 .Set("Type", "WiFi") |
| 166 .Set("WiFi", |
| 167 DictionaryBuilder() |
| 168 .Set("SSID", device_policy_ssid) |
| 169 .Set("HexSSID", base::HexEncode( |
| 170 device_policy_ssid.c_str(), |
| 171 device_policy_ssid.size())) |
| 172 .Set("Security", "None") |
| 173 .Build()) |
| 174 .Build()) |
| 175 .Build(); |
134 config_handler->SetPolicy(::onc::ONC_SOURCE_DEVICE_POLICY, "", | 176 config_handler->SetPolicy(::onc::ONC_SOURCE_DEVICE_POLICY, "", |
135 base::ListValue(), base::DictionaryValue()); | 177 *device_policy_onc, base::DictionaryValue()); |
136 } | 178 } |
137 | 179 |
138 void AddSharedNetworkToUserProfile() { | 180 void AddSharedNetworkToUserProfile() { |
139 service_test_->SetServiceProperty(kSharedWifiServicePath, | 181 service_test_->SetServiceProperty(kSharedWifiServicePath, |
140 shill::kProfileProperty, | 182 shill::kProfileProperty, |
141 base::Value(kUserProfilePath)); | 183 base::Value(kUserProfilePath)); |
142 profile_test_->AddService(kUserProfilePath, kSharedWifiServicePath); | 184 profile_test_->AddService(kUserProfilePath, kSharedWifiServicePath); |
143 | 185 |
144 base::RunLoop().RunUntilIdle(); | 186 base::RunLoop().RunUntilIdle(); |
145 } | 187 } |
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
277 scoped_refptr<NetworkingPrivateSetPropertiesFunction> set_properties = | 319 scoped_refptr<NetworkingPrivateSetPropertiesFunction> set_properties = |
278 new NetworkingPrivateSetPropertiesFunction(); | 320 new NetworkingPrivateSetPropertiesFunction(); |
279 | 321 |
280 RunFunction(set_properties.get(), | 322 RunFunction(set_properties.get(), |
281 base::StringPrintf("[\"%s\", {\"Priority\": 2}]", guid.c_str())); | 323 base::StringPrintf("[\"%s\", {\"Priority\": 2}]", guid.c_str())); |
282 EXPECT_EQ(ExtensionFunction::SUCCEEDED, *set_properties->response_type()); | 324 EXPECT_EQ(ExtensionFunction::SUCCEEDED, *set_properties->response_type()); |
283 | 325 |
284 EXPECT_EQ(2, GetNetworkPriority(network)); | 326 EXPECT_EQ(2, GetNetworkPriority(network)); |
285 } | 327 } |
286 | 328 |
| 329 TEST_F(NetworkingPrivateApiTest, CreatePrivateNetwork_NonMatchingSsids) { |
| 330 const std::string network_ssid = "new_wifi_config"; |
| 331 const std::string network_hex_ssid = |
| 332 base::HexEncode(network_ssid.c_str(), network_ssid.size()); |
| 333 std::unique_ptr<base::Value> result = RunFunctionAndReturnValue( |
| 334 new NetworkingPrivateCreateNetworkFunction(), |
| 335 base::StringPrintf("[false, {" |
| 336 " \"Priority\": 1," |
| 337 " \"Type\": \"WiFi\"," |
| 338 " \"WiFi\": {" |
| 339 " \"SSID\": \"New WiFi\"," |
| 340 " \"HexSSID\": \"%s\"," |
| 341 " \"Security\": \"WPA-PSK\"" |
| 342 "}}]", |
| 343 network_hex_ssid.c_str())); |
| 344 |
| 345 ASSERT_TRUE(result); |
| 346 ASSERT_TRUE(result->is_string()); |
| 347 |
| 348 // Test the created config can be changed now. |
| 349 const std::string guid = result->GetString(); |
| 350 const chromeos::NetworkState* network = chromeos::NetworkHandler::Get() |
| 351 ->network_state_handler() |
| 352 ->GetNetworkStateFromGuid(guid); |
| 353 ASSERT_TRUE(network); |
| 354 EXPECT_TRUE(network->IsPrivate()); |
| 355 EXPECT_EQ(1, GetNetworkPriority(network)); |
| 356 EXPECT_EQ(network_hex_ssid, network->GetHexSsid()); |
| 357 EXPECT_EQ(network_ssid, network->name()); |
| 358 } |
| 359 |
| 360 TEST_F(NetworkingPrivateApiTest, |
| 361 CreateAlreadyConfiguredUserPrivateNetwork_BySsid) { |
| 362 EXPECT_EQ("NetworkAlreadyConfigured", |
| 363 RunFunctionAndReturnError( |
| 364 new NetworkingPrivateCreateNetworkFunction(), |
| 365 base::StringPrintf("[false, {" |
| 366 " \"Priority\": 1," |
| 367 " \"Type\": \"WiFi\"," |
| 368 " \"WiFi\": {" |
| 369 " \"SSID\": \"%s\"," |
| 370 " \"Security\": \"WPA-PSK\"" |
| 371 "}}]", |
| 372 kManagedUserWifiSsid))); |
| 373 } |
| 374 |
| 375 TEST_F(NetworkingPrivateApiTest, |
| 376 CreateAlreadyConfiguredUserPrivateNetwork_ByHexSsid) { |
| 377 std::string network_hex_ssid = |
| 378 base::HexEncode(kManagedUserWifiSsid, sizeof(kManagedUserWifiSsid) - 1); |
| 379 EXPECT_EQ("NetworkAlreadyConfigured", |
| 380 RunFunctionAndReturnError( |
| 381 new NetworkingPrivateCreateNetworkFunction(), |
| 382 base::StringPrintf("[false, {" |
| 383 " \"Priority\": 1," |
| 384 " \"Type\": \"WiFi\"," |
| 385 " \"WiFi\": {" |
| 386 " \"HexSSID\": \"%s\"," |
| 387 " \"Security\": \"WPA-PSK\"" |
| 388 "}}]", |
| 389 network_hex_ssid.c_str()))); |
| 390 } |
| 391 |
| 392 TEST_F(NetworkingPrivateApiTest, |
| 393 CreateAlreadyConfiguredUserPrivateNetwork_NonMatchingSsids) { |
| 394 std::string network_hex_ssid = |
| 395 base::HexEncode(kManagedUserWifiSsid, sizeof(kManagedUserWifiSsid) - 1); |
| 396 // HexSSID should take presedence over SSID. |
| 397 EXPECT_EQ("NetworkAlreadyConfigured", |
| 398 RunFunctionAndReturnError( |
| 399 new NetworkingPrivateCreateNetworkFunction(), |
| 400 base::StringPrintf("[false, {" |
| 401 " \"Priority\": 1," |
| 402 " \"Type\": \"WiFi\"," |
| 403 " \"WiFi\": {" |
| 404 " \"SSID\": \"wrong_ssid\"," |
| 405 " \"HexSSID\": \"%s\"," |
| 406 " \"Security\": \"WPA-PSK\"" |
| 407 "}}]", |
| 408 network_hex_ssid.c_str()))); |
| 409 } |
| 410 |
| 411 TEST_F(NetworkingPrivateApiTest, |
| 412 CreateAlreadyConfiguredUserPrivateNetwork_ByHexSSID) { |
| 413 std::string network_hex_ssid = |
| 414 base::HexEncode(kManagedUserWifiSsid, sizeof(kManagedUserWifiSsid) - 1); |
| 415 EXPECT_EQ("NetworkAlreadyConfigured", |
| 416 RunFunctionAndReturnError( |
| 417 new NetworkingPrivateCreateNetworkFunction(), |
| 418 base::StringPrintf("[false, {" |
| 419 " \"Priority\": 1," |
| 420 " \"Type\": \"WiFi\"," |
| 421 " \"WiFi\": {" |
| 422 " \"HexSSID\": \"%s\"," |
| 423 " \"Security\": \"WPA-PSK\"" |
| 424 "}}]", |
| 425 network_hex_ssid.c_str()))); |
| 426 } |
| 427 |
| 428 TEST_F(NetworkingPrivateApiTest, CreateAlreadyConfiguredDeviceNetwork) { |
| 429 EXPECT_EQ( |
| 430 "NetworkAlreadyConfigured", |
| 431 RunFunctionAndReturnError(new NetworkingPrivateCreateNetworkFunction(), |
| 432 base::StringPrintf("[false, {" |
| 433 " \"Priority\": 1," |
| 434 " \"Type\": \"WiFi\"," |
| 435 " \"WiFi\": {" |
| 436 " \"SSID\": \"%s\"" |
| 437 "}}]", |
| 438 kManagedDeviceWifiSsid))); |
| 439 } |
| 440 |
| 441 TEST_F(NetworkingPrivateApiTest, |
| 442 CreateAlreadyConfiguredDeviceNetwork_ByHexSSID) { |
| 443 std::string network_hex_ssid = base::HexEncode( |
| 444 kManagedDeviceWifiSsid, sizeof(kManagedDeviceWifiSsid) - 1); |
| 445 EXPECT_EQ("NetworkAlreadyConfigured", |
| 446 RunFunctionAndReturnError( |
| 447 new NetworkingPrivateCreateNetworkFunction(), |
| 448 base::StringPrintf("[false, {" |
| 449 " \"Priority\": 1," |
| 450 " \"Type\": \"WiFi\"," |
| 451 " \"WiFi\": {" |
| 452 " \"HexSSID\": \"%s\"," |
| 453 " \"Security\": \"WPA-PSK\"" |
| 454 "}}]", |
| 455 network_hex_ssid.c_str()))); |
| 456 } |
| 457 |
287 } // namespace extensions | 458 } // namespace extensions |
OLD | NEW |