Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2767213003: First Implementation of Snapped Points

Created:
3 years, 9 months ago by sunyunjia
Modified:
3 years, 6 months ago
Reviewers:
majidvp
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, Stephen Chennney, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews, tdresser+watch_chromium.org, ajuma+watch_chromium.org, blink-reviews-api_chromium.org, kenneth.christiansen, zoltan1, blink-reviews-layout_chromium.org, sof, jbroman, pdr+graphicswatchlist_chromium.org, cc-bugs_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, dtapuska+chromiumwatch_chromium.org, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

First Implementation of Snapped Points BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Cleaned up #

Patch Set 3 : Better format #

Patch Set 4 : Matching the spec. #

Patch Set 5 : Add all CSS propertie #

Patch Set 6 : More details #

Patch Set 7 : Add the class to transfer data. #

Patch Set 8 : Implement scroll-snap-stop #

Patch Set 9 : implement scroll-snap-stop and larger area #

Patch Set 10 : Snap on gesture scroll #

Patch Set 11 : Rebased #

Patch Set 12 : Update CSS #

Patch Set 13 : Rebase and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1791 lines, -91 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +22 lines, -0 lines 0 comments Download
M cc/input/input_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M cc/layers/layer.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -0 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +14 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +11 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -0 lines 0 comments Download
A cc/layers/snap_point_list.h View 1 2 3 4 5 6 7 8 1 chunk +46 lines, -0 lines 0 comments Download
A cc/layers/snap_point_list.cc View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +125 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +139 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +188 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperty.cpp View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.json5 View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +91 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 2 3 4 5 6 7 8 9 10 3 chunks +19 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollPadding.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapAlign.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapMargin.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIScrollSnapType.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +49 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +166 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +186 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +21 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ScrollSnapPoints.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +78 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleScrollSnapData.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleScrollSnapData.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +16 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/exported/WebSnapPointList.cpp View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebGestureCurve.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/WebSnapPointList.h View 1 2 3 4 5 6 7 8 1 chunk +51 lines, -0 lines 0 comments Download
M ui/events/android/scroller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/android/scroller.cc View 1 2 3 4 5 3 chunks +33 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +16 lines, -1 line 0 comments Download
M ui/events/gesture_curve.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -0 lines 0 comments Download
M ui/events/gestures/fling_curve.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gestures/fling_curve.cc View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
sunyunjia
3 years, 7 months ago (2017-05-01 19:06:06 UTC) #6 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698