Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: components/browser_watcher/postmortem_report_extractor.cc

Issue 2767193002: Postmortem report collection: validate internal state (Closed)
Patch Set: Address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/postmortem_report_extractor.cc
diff --git a/components/browser_watcher/postmortem_report_extractor.cc b/components/browser_watcher/postmortem_report_extractor.cc
index d21abae3697858ee993d57178e52667bf8ef643b..31d8591f71756635b112f55fb85ff862909a5e9b 100644
--- a/components/browser_watcher/postmortem_report_extractor.cc
+++ b/components/browser_watcher/postmortem_report_extractor.cc
@@ -11,6 +11,7 @@
#include "base/debug/activity_analyzer.h"
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -229,6 +230,8 @@ CollectionStatus Extract(const base::FilePath& stability_file,
return DEBUG_FILE_NO_DATA;
}
+ report->set_is_complete(global_analyzer->IsDataComplete());
+
// Collect log messages.
for (const std::string& message : log_messages) {
report->add_log_messages(message);
« no previous file with comments | « components/browser_watcher/postmortem_report_collector_unittest.cc ('k') | components/browser_watcher/stability_report.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698