Postmortem report collection: validate internal state

base/debug/activity_analyzer.h

Index: base/debug/activity_analyzer.h
diff --git a/base/debug/activity_analyzer.h b/base/debug/activity_analyzer.h
index 95df69fd9b4abad4fb25eef7f8037a0ffb8785a6..cd85004a99854ec935e8f8409a91bc47adb50156 100644
--- a/base/debug/activity_analyzer.h
+++ b/base/debug/activity_analyzer.h
@@ -9,6 +9,7 @@
 #include <memory>
 #include <set>
 #include <string>
+#include <vector>
 
 #include "base/base_export.h"
 #include "base/debug/activity_tracker.h"
@@ -162,6 +163,8 @@ class BASE_EXPORT GlobalActivityAnalyzer {
   // This will return {0,0} if no mapping could be found.
   ProgramLocation GetProgramLocationFromAddress(uint64_t address);
 
+  const PersistentMemoryAllocator& allocator() { return *allocator_; }

[bcwhite, 2017/03/23 11:32:44]

For various historical reasons, allocators are always pointers rather than
references.

return allocator_.get();

But I would avoid this if possible as there may come a day when its not a single
allocator but many.   I can envision that if this moves to Renderers and
security doesn't want them sharing a file with the Browser process.

[manzagop (departed), 2017/03/23 19:18:54]

Removing this, as per your other comments.

+
  private:
   using AnalyzerMap =
       std::map<ThreadKey, std::unique_ptr<ThreadActivityAnalyzer>>;