Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: components/browser_watcher/stability_report.proto

Issue 2767193002: Postmortem report collection: validate internal state (Closed)
Patch Set: Address comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package browser_watcher; 9 package browser_watcher;
10 10
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 // A 32-bit identifier for the name of the field trial. 180 // A 32-bit identifier for the name of the field trial.
181 optional fixed32 name_id = 1; 181 optional fixed32 name_id = 1;
182 182
183 // A 32-bit identifier for the user's group within the field trial. 183 // A 32-bit identifier for the user's group within the field trial.
184 optional fixed32 group_id = 2; 184 optional fixed32 group_id = 2;
185 } 185 }
186 186
187 // A stability report contains information pertaining to the execution of a 187 // A stability report contains information pertaining to the execution of a
188 // single logical instance of a "chrome browser". It is comprised of information 188 // single logical instance of a "chrome browser". It is comprised of information
189 // about the system state and about the chrome browser's processes. 189 // about the system state and about the chrome browser's processes.
190 // Next id: 6 190 // Next id: 7
191 message StabilityReport { 191 message StabilityReport {
192 // Whether the report is complete. Reports can be incomplete when the
193 // recording size quota is hit.
194 optional bool is_complete = 6;
195
192 optional SystemState system_state = 1; 196 optional SystemState system_state = 1;
193 // TODO(manzagop): revisit whether a single repeated field should contain all 197 // TODO(manzagop): revisit whether a single repeated field should contain all
194 // processes, or whether it's preferable to have separate fields per type. 198 // processes, or whether it's preferable to have separate fields per type.
195 // TODO(manzagop): add information about the type of process, pid, process 199 // TODO(manzagop): add information about the type of process, pid, process
196 // times (e.g. start time), hierarchical relationships (e.g. parent pid), 200 // times (e.g. start time), hierarchical relationships (e.g. parent pid),
197 // command line, etc. 201 // command line, etc.
198 repeated ProcessState process_states = 2; 202 repeated ProcessState process_states = 2;
199 // TODO(manzagop): if/when reports contain multiple processes, attribute and 203 // TODO(manzagop): if/when reports contain multiple processes, attribute and
200 // relocate these to their process (and perhaps thread). 204 // relocate these to their process (and perhaps thread).
201 repeated string log_messages = 3; 205 repeated string log_messages = 3;
202 map<string, TypedValue> global_data = 4; 206 map<string, TypedValue> global_data = 4;
203 207
204 // The field trials the user is currently enrolled in. 208 // The field trials the user is currently enrolled in.
205 repeated FieldTrial field_trials = 5; 209 repeated FieldTrial field_trials = 5;
206 } 210 }
OLDNEW
« no previous file with comments | « components/browser_watcher/postmortem_report_extractor.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698