Postmortem report collection: validate internal state

base/debug/activity_analyzer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_DEBUG_ACTIVITY_ANALYZER_H_
 #define BASE_DEBUG_ACTIVITY_ANALYZER_H_
 
 #include <map>
 #include <memory>
 #include <set>
 #include <string>
+#include <vector>
 
 #include "base/base_export.h"
 #include "base/debug/activity_tracker.h"
 
 namespace base {
 namespace debug {
 
 class GlobalActivityAnalyzer;
 
 // This class provides analysis of data captured from a ThreadActivityTracker.
@@ skipping 133 matching lines @@
   // Gets all log messages stored within.
   std::vector<std::string> GetLogMessages();
 
   // Gets all the known modules.
   std::vector<GlobalActivityTracker::ModuleInfo> GetModules();
 
   // Gets the corresponding "program location" for a given "program counter".
   // This will return {0,0} if no mapping could be found.
   ProgramLocation GetProgramLocationFromAddress(uint64_t address);
 
+  const PersistentMemoryAllocator& allocator() { return *allocator_; }

[bcwhite, 2017/03/23 11:32:44]

For various historical reasons, allocators are always pointers rather than
references.

return allocator_.get();

But I would avoid this if possible as there may come a day when its not a single
allocator but many.   I can envision that if this moves to Renderers and
security doesn't want them sharing a file with the Browser process.

[manzagop (departed), 2017/03/23 19:18:54]

Removing this, as per your other comments.

+
  private:
   using AnalyzerMap =
       std::map<ThreadKey, std::unique_ptr<ThreadActivityAnalyzer>>;
 
   // Finds, creates, and indexes analyzers for all known processes and threads.
   void PrepareAllAnalyzers();
 
   // The persistent memory allocator holding all tracking data.
   std::unique_ptr<PersistentMemoryAllocator> allocator_;
 
@@ skipping 10 matching lines @@
   // first/next iteration.
   AnalyzerMap::iterator analyzers_iterator_;
 
   DISALLOW_COPY_AND_ASSIGN(GlobalActivityAnalyzer);
 };
 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_ACTIVITY_ANALYZER_H_