Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: ash/shelf/shelf_view_unittest.cc

Issue 2767133002: Makes a couple of overflow button tests early out in mash (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/common/shelf/shelf_view.h" 5 #include "ash/common/shelf/shelf_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2651 matching lines...) Expand 10 before | Expand all | Expand 10 after
2662 overflow_button_ink_drop_->GetTargetInkDropState()); 2662 overflow_button_ink_drop_->GetTargetInkDropState());
2663 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2663 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2664 IsEmpty()); 2664 IsEmpty());
2665 2665
2666 EXPECT_FALSE(test_api_->IsShowingOverflowBubble()); 2666 EXPECT_FALSE(test_api_->IsShowingOverflowBubble());
2667 } 2667 }
2668 2668
2669 // Tests ink drop state transitions for the overflow button when the user taps 2669 // Tests ink drop state transitions for the overflow button when the user taps
2670 // on it. 2670 // on it.
2671 TEST_F(OverflowButtonInkDropTest, TouchActivate) { 2671 TEST_F(OverflowButtonInkDropTest, TouchActivate) {
2672 // TODO: flaky in mash, figure out why. http://crbug.com/696769.
2673 if (WmShell::Get()->IsRunningInMash())
2674 return;
2675
2672 ui::test::EventGenerator& generator = GetEventGenerator(); 2676 ui::test::EventGenerator& generator = GetEventGenerator();
2673 generator.set_current_location(GetScreenPointInsideOverflowButton()); 2677 generator.set_current_location(GetScreenPointInsideOverflowButton());
2674 2678
2675 generator.PressTouch(); 2679 generator.PressTouch();
2676 EXPECT_EQ(views::InkDropState::ACTION_PENDING, 2680 EXPECT_EQ(views::InkDropState::ACTION_PENDING,
2677 overflow_button_ink_drop_->GetTargetInkDropState()); 2681 overflow_button_ink_drop_->GetTargetInkDropState());
2678 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2682 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2679 ElementsAre(views::InkDropState::ACTION_PENDING)); 2683 ElementsAre(views::InkDropState::ACTION_PENDING));
2680 2684
2681 generator.ReleaseTouch(); 2685 generator.ReleaseTouch();
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
2844 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2848 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2845 IsEmpty()); 2849 IsEmpty());
2846 2850
2847 ASSERT_TRUE(test_api_->IsShowingOverflowBubble()); 2851 ASSERT_TRUE(test_api_->IsShowingOverflowBubble());
2848 } 2852 }
2849 2853
2850 // Tests ink drop state transitions for the overflow button when it is active 2854 // Tests ink drop state transitions for the overflow button when it is active
2851 // and the user presses left mouse button on it and drags it out of the button 2855 // and the user presses left mouse button on it and drags it out of the button
2852 // bounds and back. 2856 // bounds and back.
2853 TEST_F(OverflowButtonActiveInkDropTest, MouseDragOutAndBack) { 2857 TEST_F(OverflowButtonActiveInkDropTest, MouseDragOutAndBack) {
2858 // TODO: flaky in mash, figure out why. http://crbug.com/696769.
2859 if (WmShell::Get()->IsRunningInMash())
2860 return;
2861
2854 ui::test::EventGenerator& generator = GetEventGenerator(); 2862 ui::test::EventGenerator& generator = GetEventGenerator();
2855 generator.MoveMouseTo(GetScreenPointInsideOverflowButton()); 2863 generator.MoveMouseTo(GetScreenPointInsideOverflowButton());
2856 2864
2857 generator.PressLeftButton(); 2865 generator.PressLeftButton();
2858 EXPECT_EQ(views::InkDropState::ACTIVATED, 2866 EXPECT_EQ(views::InkDropState::ACTIVATED,
2859 overflow_button_ink_drop_->GetTargetInkDropState()); 2867 overflow_button_ink_drop_->GetTargetInkDropState());
2860 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2868 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2861 IsEmpty()); 2869 IsEmpty());
2862 2870
2863 generator.MoveMouseTo(GetScreenPointOutsideOverflowButton()); 2871 generator.MoveMouseTo(GetScreenPointOutsideOverflowButton());
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
2920 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2928 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2921 ElementsAre(views::InkDropState::DEACTIVATED, 2929 ElementsAre(views::InkDropState::DEACTIVATED,
2922 views::InkDropState::HIDDEN)); 2930 views::InkDropState::HIDDEN));
2923 2931
2924 EXPECT_FALSE(test_api_->IsShowingOverflowBubble()); 2932 EXPECT_FALSE(test_api_->IsShowingOverflowBubble());
2925 } 2933 }
2926 2934
2927 // Tests ink drop state transitions for the overflow button when it is active 2935 // Tests ink drop state transitions for the overflow button when it is active
2928 // and the user taps down on it and drags it out of the button bounds. 2936 // and the user taps down on it and drags it out of the button bounds.
2929 TEST_F(OverflowButtonActiveInkDropTest, TouchDragOut) { 2937 TEST_F(OverflowButtonActiveInkDropTest, TouchDragOut) {
2938 // TODO: flaky in mash, figure out why. http://crbug.com/696769.
2939 if (WmShell::Get()->IsRunningInMash())
2940 return;
2941
2930 ui::test::EventGenerator& generator = GetEventGenerator(); 2942 ui::test::EventGenerator& generator = GetEventGenerator();
2931 generator.set_current_location(GetScreenPointInsideOverflowButton()); 2943 generator.set_current_location(GetScreenPointInsideOverflowButton());
2932 2944
2933 generator.PressTouch(); 2945 generator.PressTouch();
2934 EXPECT_EQ(views::InkDropState::ACTIVATED, 2946 EXPECT_EQ(views::InkDropState::ACTIVATED,
2935 overflow_button_ink_drop_->GetTargetInkDropState()); 2947 overflow_button_ink_drop_->GetTargetInkDropState());
2936 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2948 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2937 IsEmpty()); 2949 IsEmpty());
2938 2950
2939 generator.MoveTouch(GetScreenPointOutsideOverflowButton()); 2951 generator.MoveTouch(GetScreenPointOutsideOverflowButton());
2940 EXPECT_EQ(views::InkDropState::ACTIVATED, 2952 EXPECT_EQ(views::InkDropState::ACTIVATED,
2941 overflow_button_ink_drop_->GetTargetInkDropState()); 2953 overflow_button_ink_drop_->GetTargetInkDropState());
2942 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2954 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2943 IsEmpty()); 2955 IsEmpty());
2944 2956
2945 generator.ReleaseTouch(); 2957 generator.ReleaseTouch();
2946 EXPECT_EQ(views::InkDropState::ACTIVATED, 2958 EXPECT_EQ(views::InkDropState::ACTIVATED,
2947 overflow_button_ink_drop_->GetTargetInkDropState()); 2959 overflow_button_ink_drop_->GetTargetInkDropState());
2948 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2960 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2949 IsEmpty()); 2961 IsEmpty());
2950 2962
2951 ASSERT_TRUE(test_api_->IsShowingOverflowBubble()); 2963 ASSERT_TRUE(test_api_->IsShowingOverflowBubble());
2952 } 2964 }
2953 2965
2954 // Tests ink drop state transitions for the overflow button when it is active 2966 // Tests ink drop state transitions for the overflow button when it is active
2955 // and the user taps down on it and drags it out of the button bounds and back. 2967 // and the user taps down on it and drags it out of the button bounds and back.
2956 TEST_F(OverflowButtonActiveInkDropTest, TouchDragOutAndBack) { 2968 TEST_F(OverflowButtonActiveInkDropTest, TouchDragOutAndBack) {
2969 // TODO: flaky in mash, figure out why. http://crbug.com/696769.
2970 if (WmShell::Get()->IsRunningInMash())
2971 return;
2972
2957 ui::test::EventGenerator& generator = GetEventGenerator(); 2973 ui::test::EventGenerator& generator = GetEventGenerator();
2958 generator.set_current_location(GetScreenPointInsideOverflowButton()); 2974 generator.set_current_location(GetScreenPointInsideOverflowButton());
2959 2975
2960 generator.PressTouch(); 2976 generator.PressTouch();
2961 EXPECT_EQ(views::InkDropState::ACTIVATED, 2977 EXPECT_EQ(views::InkDropState::ACTIVATED,
2962 overflow_button_ink_drop_->GetTargetInkDropState()); 2978 overflow_button_ink_drop_->GetTargetInkDropState());
2963 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 2979 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
2964 IsEmpty()); 2980 IsEmpty());
2965 2981
2966 generator.MoveTouch(GetScreenPointOutsideOverflowButton()); 2982 generator.MoveTouch(GetScreenPointOutsideOverflowButton());
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
3012 EXPECT_EQ(views::InkDropState::ACTIVATED, 3028 EXPECT_EQ(views::InkDropState::ACTIVATED,
3013 overflow_button_ink_drop_->GetTargetInkDropState()); 3029 overflow_button_ink_drop_->GetTargetInkDropState());
3014 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(), 3030 EXPECT_THAT(overflow_button_ink_drop_->GetAndResetRequestedStates(),
3015 IsEmpty()); 3031 IsEmpty());
3016 3032
3017 ASSERT_TRUE(test_api_->IsShowingOverflowBubble()); 3033 ASSERT_TRUE(test_api_->IsShowingOverflowBubble());
3018 } 3034 }
3019 3035
3020 } // namespace test 3036 } // namespace test
3021 } // namespace ash 3037 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698