third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2767063002: 16-bit video upload to float: intermediate R16_EXT and copy to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2767063002: 16-bit video upload to float: intermediate R16_EXT and copy to float. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/renderers/skcanvas_video_renderer.cc ('K') | « third_party/WebKit/Source/core/html/HTMLVideoElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 3982dddc41d4fd2a2963f8324dfcbaff0c419407..5d07622ba0d98215276841679f3214778805ac83 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -5336,8 +5336,9 @@ void WebGLRenderingContextBase::texImageHelperHTMLVideoElement(

this, m_unpackFlipY || m_unpackPremultiplyAlpha);

if (video->texImageImpl(

static_cast<WebMediaPlayer::TexImageFunctionID>(functionID), target,

- contextGL(), level, convertTexInternalFormat(internalformat, type),

- format, type, xoffset, yoffset, zoffset, m_unpackFlipY,

+ contextGL(), texture->object(), level,

+ convertTexInternalFormat(internalformat, type), format, type,

+ xoffset, yoffset, zoffset, m_unpackFlipY,

m_unpackPremultiplyAlpha &&

m_unpackColorspaceConversion == GL_NONE)) {

texture->updateLastUploadedVideo(video->webMediaPlayer());