16-bit video upload to float: intermediate R16_EXT and copy to float.

media/renderers/skcanvas_video_renderer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_RENDERERS_SKCANVAS_VIDEO_RENDERER_H_
 #define MEDIA_RENDERERS_SKCANVAS_VIDEO_RENDERER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 10 matching lines @@
 #include "media/base/video_rotation.h"
 #include "media/filters/context_3d.h"
 #include "third_party/skia/include/core/SkImage.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 
 
 namespace gfx {
 class RectF;
 }
 
+namespace gpu {
+struct Capabilities;
+}
+
 namespace media {
 
 // TODO(enne): rename to PaintCanvasVideoRenderer
 // Handles rendering of VideoFrames to PaintCanvases.
 class MEDIA_EXPORT SkCanvasVideoRenderer {
  public:
   SkCanvasVideoRenderer();
   ~SkCanvasVideoRenderer();
 
   // Paints |video_frame| on |canvas|, scaling and rotating the result to fit
@@ skipping 52 matching lines @@
       unsigned int texture,
       bool premultiply_alpha,
       bool flip_y);
 
   // Converts unsigned 16-bit value to target |format| for Y16 format and
   // calls WebGL texImage2D.
   // |level|, |internal_format|, |format|, |type| are WebGL texImage2D
   // parameters.
   // Returns false if there is no implementation for given parameters.
   static bool TexImage2D(unsigned target,
+                         unsigned texture,

[Ken Russell (switch to Gerrit), 2017/04/20 01:47:07]

Please document |texture| -- i.e., if it's the one currently bound to |target|,
what is the state of the binding to |target| upon return, etc.

Also, if this is really only used for 16-bit textures, then "TexImage2D" is too
generic and confusing a name, and I'd ask that you rename it to something like
"TexImage2DY16" and change the call sites.

[aleksandar.stojiljkovic, 2017/04/26 13:29:40]

Done.
Plan to use it at least for Y8 and will try to optimize HDR RGB10_A2 upload
using it. Changed the description to clarify it.

                          gpu::gles2::GLES2Interface* gl,
+                         const gpu::Capabilities& gpu_capabilities,
                          VideoFrame* video_frame,
                          int level,
                          int internalformat,
                          unsigned format,
                          unsigned type,
                          bool flip_y,
                          bool premultiply_alpha);
 
   // Converts unsigned 16-bit value to target |format| for Y16 format and
   // calls WebGL texSubImage2D.
   // |level|, |format|, |type|, |xoffset| and |yoffset| are texSubImage2D
   // parameters.
   // Returns false if there is no implementation for given parameters.
   static bool TexSubImage2D(unsigned target,

[Ken Russell (switch to Gerrit), 2017/04/20 01:47:06]

Same comment about the naming of this function.

                             gpu::gles2::GLES2Interface* gl,
                             VideoFrame* video_frame,
                             int level,
                             unsigned format,
                             unsigned type,
                             int xoffset,
                             int yoffset,
                             bool flip_y,
                             bool premultiply_alpha);
 
@@ skipping 26 matching lines @@
 
   // Used for unit test.
   SkISize last_image_dimensions_for_testing_;
 
   DISALLOW_COPY_AND_ASSIGN(SkCanvasVideoRenderer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_RENDERERS_SKCANVAS_VIDEO_RENDERER_H_