Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: net/http/http_cache_transaction.h

Issue 2766953002: [HttpCache::Transaction] Force states to set the next state (Closed)
Patch Set: Nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/http/http_cache_transaction.cc » ('j') | net/http/http_cache_transaction.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1
Randy Smith (Not in Mondays) 2017/03/22 14:49:44 nit: Why?
jkarlin 2017/03/22 15:04:26 Done.
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 4 // found in the LICENSE file.
4 5
5 // This file declares HttpCache::Transaction, a private class of HttpCache so 6 // This file declares HttpCache::Transaction, a private class of HttpCache so
6 // it should only be included by http_cache.cc 7 // it should only be included by http_cache.cc
7 8
8 #ifndef NET_HTTP_HTTP_CACHE_TRANSACTION_H_ 9 #ifndef NET_HTTP_HTTP_CACHE_TRANSACTION_H_
9 #define NET_HTTP_HTTP_CACHE_TRANSACTION_H_ 10 #define NET_HTTP_HTTP_CACHE_TRANSACTION_H_
10 11
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // Helper struct to pair a header name with its value, for 173 // Helper struct to pair a header name with its value, for
173 // headers used to validate cache entries. 174 // headers used to validate cache entries.
174 struct ValidationHeaders { 175 struct ValidationHeaders {
175 ValidationHeaders() : initialized(false) {} 176 ValidationHeaders() : initialized(false) {}
176 177
177 std::string values[kNumValidationHeaders]; 178 std::string values[kNumValidationHeaders];
178 bool initialized; 179 bool initialized;
179 }; 180 };
180 181
181 enum State { 182 enum State {
183 STATE_UNSET,
184
182 // Normally, states are traversed in approximately this order. 185 // Normally, states are traversed in approximately this order.
183 STATE_NONE, 186 STATE_NONE,
184 STATE_GET_BACKEND, 187 STATE_GET_BACKEND,
185 STATE_GET_BACKEND_COMPLETE, 188 STATE_GET_BACKEND_COMPLETE,
186 STATE_INIT_ENTRY, 189 STATE_INIT_ENTRY,
187 STATE_OPEN_ENTRY, 190 STATE_OPEN_ENTRY,
188 STATE_OPEN_ENTRY_COMPLETE, 191 STATE_OPEN_ENTRY_COMPLETE,
189 STATE_DOOM_ENTRY, 192 STATE_DOOM_ENTRY,
190 STATE_DOOM_ENTRY_COMPLETE, 193 STATE_DOOM_ENTRY_COMPLETE,
191 STATE_CREATE_ENTRY, 194 STATE_CREATE_ENTRY,
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 BeforeHeadersSentCallback before_headers_sent_callback_; 510 BeforeHeadersSentCallback before_headers_sent_callback_;
508 511
509 base::WeakPtrFactory<Transaction> weak_factory_; 512 base::WeakPtrFactory<Transaction> weak_factory_;
510 513
511 DISALLOW_COPY_AND_ASSIGN(Transaction); 514 DISALLOW_COPY_AND_ASSIGN(Transaction);
512 }; 515 };
513 516
514 } // namespace net 517 } // namespace net
515 518
516 #endif // NET_HTTP_HTTP_CACHE_TRANSACTION_H_ 519 #endif // NET_HTTP_HTTP_CACHE_TRANSACTION_H_
OLDNEW
« no previous file with comments | « no previous file | net/http/http_cache_transaction.cc » ('j') | net/http/http_cache_transaction.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698