Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2766893002: Remove logic about recording style related main thread scroll reasons (Closed)
Patch Set: Add TODO comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 5075 matching lines...) Expand 10 before | Expand all | Expand 10 after
5086 const { 5086 const {
5087 MainThreadScrollingReasons reasons = 5087 MainThreadScrollingReasons reasons =
5088 static_cast<MainThreadScrollingReasons>(0); 5088 static_cast<MainThreadScrollingReasons>(0);
5089 5089
5090 if (shouldThrottleRendering()) 5090 if (shouldThrottleRendering())
5091 return reasons; 5091 return reasons;
5092 5092
5093 if (hasBackgroundAttachmentFixedObjects()) 5093 if (hasBackgroundAttachmentFixedObjects())
5094 reasons |= MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects; 5094 reasons |= MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
5095 5095
5096 reasons |= getStyleRelatedMainThreadScrollingReasons();
5097
5098 ScrollingReasons scrollingReasons = getScrollingReasons(); 5096 ScrollingReasons scrollingReasons = getScrollingReasons();
5099 const bool mayBeScrolledByInput = (scrollingReasons == Scrollable); 5097 const bool mayBeScrolledByInput = (scrollingReasons == Scrollable);
5100 const bool mayBeScrolledByScript = 5098 const bool mayBeScrolledByScript =
5101 mayBeScrolledByInput || 5099 mayBeScrolledByInput ||
5102 (scrollingReasons == NotScrollableExplicitlyDisabled); 5100 (scrollingReasons == NotScrollableExplicitlyDisabled);
5103 5101
5104 // TODO(awoloszyn) Currently crbug.com/304810 will let certain 5102 // TODO(awoloszyn) Currently crbug.com/304810 will let certain
5105 // overflow:hidden elements scroll on the compositor thread, so we should 5103 // overflow:hidden elements scroll on the compositor thread, so we should
5106 // not let this move there path as an optimization, when we have 5104 // not let this move there path as an optimization, when we have
5107 // slow-repaint elements. 5105 // slow-repaint elements.
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
5261 void FrameView::setAnimationHost( 5259 void FrameView::setAnimationHost(
5262 std::unique_ptr<CompositorAnimationHost> host) { 5260 std::unique_ptr<CompositorAnimationHost> host) {
5263 m_animationHost = std::move(host); 5261 m_animationHost = std::move(host);
5264 } 5262 }
5265 5263
5266 LayoutUnit FrameView::caretWidth() const { 5264 LayoutUnit FrameView::caretWidth() const {
5267 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5265 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5268 } 5266 }
5269 5267
5270 } // namespace blink 5268 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698