Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html

Issue 2766883002: Allow status = 0 when XHR is completed in Audit.loadFileFromUrl(). (Closed)
Patch Set: Fix Audit.loadAudioFileFromUrl() Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
index ea959d546da6c768d9a3fece4c371c95a86999b2..4015616b2a7be624ee4acd020b78e566ede44a03 100644
--- a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
+++ b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
@@ -85,6 +85,19 @@
task.done();
});
+ // Testing the failure handling of Audit.loadFileFromUrl().
+ audit.define({
+ label: 'load-file-in-should',
+ description: 'Testing the failure handling of Audit.loadFileFromUrl().'
+ }, (task, should) => {
+ let url = 'non-existent-audio-file.wav';
+ let promise = should(Audit.loadFileFromUrl(url),
+ 'Loading file within should().beResolved()')
Raymond Toy 2017/03/21 21:16:33 "Loading file" -> "Loading non-existent file"
hongchan 2017/03/21 23:07:57 Done.
+ .beResolved();
+ promise.then(() => { task.done() });
+ }
+ );
+
// With no argument, this executes all tasks in the order defined.
audit.run();
</script>

Powered by Google App Engine
This is Rietveld 408576698