Issue 276683003: Password bubble: Deal correctly with blacklist state changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276683003: Password bubble: Deal correctly with blacklist state changes. (Closed)

Created:
6 years, 7 months ago by Mike West

Modified:
6 years, 7 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, mkwst+watchlist_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Password bubble: Deal correctly with blacklist state changes. If a user blacklists or unblacklists a site in a separate tab, we need to correctly update every other tab's state (consider the unlikely case of logging into the same site 8 times at the same time in separate tabs, or the slightly less unlikely case of changing status in chrome://settings/passwords while a login page is visible). This CL updates the observer logic to account for blacklist entries being added and removed from the PasswordStore, and updates the UI accordingly. BUG=261628 R=vabr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269244

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
	M	chrome/browser/ui/passwords/manage_passwords_ui_controller.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc	View		2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

Mind taking a look at this change, Vaclav? Thanks! -mike

6 years, 7 months ago (2014-05-08 12:47:30 UTC) #1

vabr (Chromium)

LGTM, code makes sense, and test explain what happens. The ideal state! I'm tempted to ...

6 years, 7 months ago (2014-05-08 14:41:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/276683003/20001

6 years, 7 months ago (2014-05-08 14:54:23 UTC) #4

Mike West

6 years, 7 months ago (2014-05-09 12:34:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r269244 (presubmit successful).

Expand Messages | Collapse Messages