third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py - Issue 2766823003: Fix testharness result parsing, make "Harness error" count as failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

Issue 2766823003: Fix testharness result parsing, make "Harness error" count as failure. (Closed)

Patch Set: One more test with nondeterministic message order Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

index 2c78e0cc047abbde89aa09cb264c51fb609f58d2..7169e19d05f4d650b7eaaa93c21ae2f4ec768dc1 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results_unittest.py

@@ -30,6 +30,11 @@ class TestHarnessResultCheckerTest(unittest.TestCase):

' PASS: foo bar \n'

'FAIL \n'

' Harness: the test ran to completion.'))

+ self.assertFalse(testharness_results.is_all_pass_testharness_result(

+ 'This is a testharness.js-based test.\n'

+ 'Harness Error. harness_status.status = 1\n'

+ 'PASS foo bar\n'

+ 'Harness: the test ran to completion.'))

def test_is_testharness_output_positive_cases(self):

self.assertTrue(testharness_results.is_testharness_output(

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/testharness_results.py ('k') | no next file » | no next file with comments »