Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm

Issue 2766663002: Rename CommandDispatcher method to start dispatching. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm
diff --git a/ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm b/ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm
index 3154e5374f35bfcb737c98dc421f188a2eebad2f..94460e0b02c3632b6df6181fa7f0e2c6381c4303 100644
--- a/ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm
+++ b/ios/clean/chrome/browser/ui/commands/command_dispatcher_unittest.mm
@@ -116,8 +116,8 @@ TEST(CommandDispatcherTest, SimpleTarget) {
CommandDispatcherTestSimpleTarget* target =
[[CommandDispatcherTestSimpleTarget alloc] init];
- [dispatcher registerTarget:target forSelector:@selector(show)];
- [dispatcher registerTarget:target forSelector:@selector(hide)];
+ [dispatcher startDispatchingToTarget:target forSelector:@selector(show)];
+ [dispatcher startDispatchingToTarget:target forSelector:@selector(hide)];
[dispatcher show];
EXPECT_TRUE(target.showCalled);
@@ -135,10 +135,13 @@ TEST(CommandDispatcherTest, TargetWithArguments) {
CommandDispatcherTestTargetWithArguments* target =
[[CommandDispatcherTestTargetWithArguments alloc] init];
- [dispatcher registerTarget:target forSelector:@selector(methodWithInt:)];
- [dispatcher registerTarget:target forSelector:@selector(methodWithObject:)];
- [dispatcher registerTarget:target
- forSelector:@selector(methodToAddFirstArgument:toSecond:)];
+ [dispatcher startDispatchingToTarget:target
+ forSelector:@selector(methodWithInt:)];
+ [dispatcher startDispatchingToTarget:target
+ forSelector:@selector(methodWithObject:)];
+ [dispatcher
+ startDispatchingToTarget:target
+ forSelector:@selector(methodToAddFirstArgument:toSecond:)];
const int int_argument = 4;
[dispatcher methodWithInt:int_argument];
@@ -169,8 +172,8 @@ TEST(CommandDispatcherTest, MultipleTargets) {
CommandDispatcherTestSimpleTarget* hideTarget =
[[CommandDispatcherTestSimpleTarget alloc] init];
- [dispatcher registerTarget:showTarget forSelector:@selector(show)];
- [dispatcher registerTarget:hideTarget forSelector:@selector(hide)];
+ [dispatcher startDispatchingToTarget:showTarget forSelector:@selector(show)];
+ [dispatcher startDispatchingToTarget:hideTarget forSelector:@selector(hide)];
[dispatcher show];
EXPECT_TRUE(showTarget.showCalled);
@@ -190,8 +193,8 @@ TEST(CommandDispatcherTest, Deregistration) {
CommandDispatcherTestSimpleTarget* hideTarget =
[[CommandDispatcherTestSimpleTarget alloc] init];
- [dispatcher registerTarget:showTarget forSelector:@selector(show)];
- [dispatcher registerTarget:hideTarget forSelector:@selector(hide)];
+ [dispatcher startDispatchingToTarget:showTarget forSelector:@selector(show)];
+ [dispatcher startDispatchingToTarget:hideTarget forSelector:@selector(hide)];
[dispatcher show];
EXPECT_TRUE(showTarget.showCalled);
@@ -219,7 +222,7 @@ TEST(CommandDispatcherTest, NoTargetRegisteredForSelector) {
CommandDispatcherTestSimpleTarget* target =
[[CommandDispatcherTestSimpleTarget alloc] init];
- [dispatcher registerTarget:target forSelector:@selector(show)];
+ [dispatcher startDispatchingToTarget:target forSelector:@selector(show)];
bool exception_caught = false;
@try {

Powered by Google App Engine
This is Rietveld 408576698