net/quic/chromium/quic_chromium_client_session.cc - Issue 2766603004: QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2766603004: QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_chromium_client_session.cc

diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc

index d783551a80145c58032a9ce31a09b2446bc0f9d6..194b18c72a7285b17a68cce89b00a6780ee66895 100644

--- a/net/quic/chromium/quic_chromium_client_session.cc

+++ b/net/quic/chromium/quic_chromium_client_session.cc

@@ -680,6 +680,9 @@ int QuicChromiumClientSession::CryptoConnect(

if (!require_confirmation_ && IsEncryptionEstablished())

return OK;

+ if (!connection()->connected())

+ return ERR_QUIC_HANDSHAKE_FAILED;

Ryan Hamilton 2017/03/22 02:38:48 Please move this to immediately after the call to

Zhongyi Shi 2017/03/22 07:00:11 Done.

callback_ = callback;

return ERR_IO_PENDING;

}