QUIC: mark QUIC handshake failed if connection is closed after CryptoConnect

net/quic/test_tools/mock_crypto_client_stream.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_H_
 #define NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 17 matching lines @@
     // in the field, but is convenient for higher level tests.
     CONFIRM_HANDSHAKE,
 
     // ZERO_RTT indicates that CryptoConnect will establish encryption but will
     // not confirm the handshake.
     ZERO_RTT,
 
     // COLD_START indicates that CryptoConnect will neither establish encryption
     // nor confirm the handshake
     COLD_START,
+
+    // USE_DEFAULT_CRYPTO_STREAM indicates that MockCryptoClientStreamFactory

[xunjieli, 2017/03/23 16:18:02]

Hmm.. even though this is test code, there is layering violation here. Can you
move the enum to the Factory class?

[Zhongyi Shi, 2017/03/23 17:28:50]

I prefer to move this to another CL, since if we move the enum to the factory in
this CL, it will introduce a lot of test changes. Considering this CL will be
merged to other milestones, shall we keep it simple as is here? 

[xunjieli, 2017/03/23 17:43:37]

SG. Can we add a crbug to track it?

+    // will create a QuicCryptoClientStream instead of a
+    // MockCryptoClientStream.
+    USE_DEFAULT_CRYPTO_STREAM,
   };
 
   MockCryptoClientStream(
       const QuicServerId& server_id,
       QuicClientSessionBase* session,
       ProofVerifyContext* verify_context,
       const QuicConfig& config,
       QuicCryptoClientConfig* crypto_config,
       HandshakeMode handshake_mode,
       const ProofVerifyDetailsChromium* proof_verify_details_);
@@ skipping 17 matching lines @@
   const QuicServerId server_id_;
   const ProofVerifyDetailsChromium* proof_verify_details_;
   const QuicConfig config_;
 
   DISALLOW_COPY_AND_ASSIGN(MockCryptoClientStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_H_