Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: src/objects.cc

Issue 2766573003: [debug] introduce precise binary code coverage. (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index a63255a931090e60b01e5caf48e2747cdc9a7c97..66c5a2ff7ec73874de7874280fd30d7299cfe55b 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -13458,10 +13458,14 @@ Handle<Object> SharedFunctionInfo::GetSourceCodeHarmony() {
bool SharedFunctionInfo::IsInlineable() {
// Check that the function has a script associated with it.
if (!script()->IsScript()) return false;
+ if (GetIsolate()->is_precise_binary_code_coverage() &&
+ !has_reported_binary_coverage()) {
+ // We may miss invocations if this function is inlined.
+ return false;
+ }
return !optimization_disabled();
}
-
int SharedFunctionInfo::SourceSize() {
return end_position() - start_position();
}
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698