Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: mojo/public/cpp/bindings/tests/bindings_perftest.cc

Issue 2766523002: mojo: MessageReceiver*::AcceptWithResponder() now take a unique_ptr to the responder (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/bindings_perftest.cc
diff --git a/mojo/public/cpp/bindings/tests/bindings_perftest.cc b/mojo/public/cpp/bindings/tests/bindings_perftest.cc
index 6a50de46f93bad397468017dbebec3627fed9dda..6e613a858eefa70a442b6615bacf4385924bc8d2 100644
--- a/mojo/public/cpp/bindings/tests/bindings_perftest.cc
+++ b/mojo/public/cpp/bindings/tests/bindings_perftest.cc
@@ -139,9 +139,12 @@ TEST_F(MojoBindingsPerftest, InProcessPingPong) {
class PingPongPaddle : public MessageReceiverWithResponderStatus {
public:
- PingPongPaddle(MessageReceiver* sender) : sender_(sender) {}
+ PingPongPaddle(std::unique_ptr<MessageReceiver> sender)
+ : sender_(std::move(sender)) {}
- void set_sender(MessageReceiver* sender) { sender_ = sender; }
+ void set_sender(std::unique_ptr<MessageReceiver> sender) {
+ sender_ = std::move(sender);
+ }
bool Accept(Message* message) override {
uint32_t count = message->header()->name;
@@ -160,8 +163,9 @@ class PingPongPaddle : public MessageReceiverWithResponderStatus {
return true;
}
- bool AcceptWithResponder(Message* message,
- MessageReceiverWithStatus* responder) override {
+ bool AcceptWithResponder(
+ Message* message,
+ std::unique_ptr<MessageReceiverWithStatus> responder) override {
NOTREACHED();
return true;
}
@@ -186,7 +190,7 @@ class PingPongPaddle : public MessageReceiverWithResponderStatus {
base::TimeTicks start_time_;
base::TimeTicks end_time_;
uint32_t expected_count_ = 0;
- MessageReceiver* sender_;
+ std::unique_ptr<MessageReceiver> sender_;
base::Closure quit_closure_;
};
@@ -232,8 +236,9 @@ class CounterReceiver : public MessageReceiverWithResponderStatus {
return true;
}
- bool AcceptWithResponder(Message* message,
- MessageReceiverWithStatus* responder) override {
+ bool AcceptWithResponder(
+ Message* message,
+ std::unique_ptr<MessageReceiverWithStatus> responder) override {
NOTREACHED();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698