mojo: MessageReceiver*::AcceptWithResponder() now take a unique_ptr to the responder

mojo/public/cpp/bindings/message.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 166 matching lines @@
 
 class MessageReceiverWithResponder : public MessageReceiver {
  public:
   ~MessageReceiverWithResponder() override {}
 
   // A variant on Accept that registers a MessageReceiver (known as the
   // responder) to handle the response message generated from the given
   // message. The responder's Accept method may be called during
   // AcceptWithResponder or some time after its return.
   //
-  // NOTE: Upon returning true, AcceptWithResponder assumes ownership of
-  // |responder| and will delete it after calling |responder->Accept| or upon
-  // its own destruction.
-  //
-  // TODO(yzshen): consider changing |responder| to
-  // std::unique_ptr<MessageReceiver>.
-  virtual bool AcceptWithResponder(Message* message, MessageReceiver* responder)
+  // NOTE: If AcceptWithReponder returns false, |responder| may be deleted
+  // immediately. Otherwise it will delete it after calling |responder->Accept|
+  // or upon its own destruction.
+  virtual bool AcceptWithResponder(Message* message,
+                                   std::unique_ptr<MessageReceiver> responder)
       WARN_UNUSED_RESULT = 0;
 };
 
 // A MessageReceiver that is also able to provide status about the state
 // of the underlying MessagePipe to which it will be forwarding messages
 // received via the |Accept()| call.
 class MessageReceiverWithStatus : public MessageReceiver {
  public:
   ~MessageReceiverWithStatus() override {}
 
@@ skipping 12 matching lines @@
 // of the MessagePipe which will carry the responses.
 class MessageReceiverWithResponderStatus : public MessageReceiver {
  public:
   ~MessageReceiverWithResponderStatus() override {}
 
   // A variant on Accept that registers a MessageReceiverWithStatus (known as
   // the responder) to handle the response message generated from the given
   // message. Any of the responder's methods (Accept or IsValid) may be called
   // during  AcceptWithResponder or some time after its return.
   //
-  // NOTE: Upon returning true, AcceptWithResponder assumes ownership of
-  // |responder| and will delete it after calling |responder->Accept| or upon
-  // its own destruction.
-  //
-  // TODO(yzshen): consider changing |responder| to
-  // std::unique_ptr<MessageReceiver>.
+  // NOTE: If AcceptWithReponder returns false, |responder| may be deleted
+  // immediately. Otherwise it will delete it after calling |responder->Accept|

[yzshen1, 2017/03/21 16:10:00]

ditto.

[watk, 2017/03/22 07:09:15]

Done.

+  // or upon its own destruction.
   virtual bool AcceptWithResponder(Message* message,
-                                   MessageReceiverWithStatus* responder)
-      WARN_UNUSED_RESULT = 0;
+                                   std::unique_ptr<MessageReceiverWithStatus>
+                                       responder) WARN_UNUSED_RESULT = 0;
 };
 
 class MOJO_CPP_BINDINGS_EXPORT PassThroughFilter
     : NON_EXPORTED_BASE(public MessageReceiver) {
  public:
   PassThroughFilter();
   ~PassThroughFilter() override;
 
   // MessageReceiver:
   bool Accept(Message* message) override;
@@ skipping 61 matching lines @@
 // Message as bad. Note that this is only legal to call from directly within the
 // stack frame of a message dispatch, but the returned callback may be called
 // exactly once any time thereafter to report the message as bad. This may only
 // be called once per message.
 MOJO_CPP_BINDINGS_EXPORT
 ReportBadMessageCallback GetBadMessageCallback();
 
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_