Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: runtime/observatory/tests/service/service_kernel.status

Issue 2766513004: Don't run service tests via dartk in debug mode (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/service_kernel.status
diff --git a/runtime/observatory/tests/service/service_kernel.status b/runtime/observatory/tests/service/service_kernel.status
index db44ffb9cb02a4facf613d45bcc5a890fa7b6329..5b38a639146947a6a8199f8b5d6a14f430b02e5c 100644
--- a/runtime/observatory/tests/service/service_kernel.status
+++ b/runtime/observatory/tests/service/service_kernel.status
@@ -5,6 +5,9 @@
[ $compiler == dartkp ]
*: Skip # Non-kernel also skips precompiled mode.
+[ $compiler == dartk && $mode == debug ]
+*: Skip # ~2/3 fail because of finalization issues. Issue #29123.
+
[ $compiler == dartk ]
###
### Kernel works slightly different. There are kernel specific versions.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698