Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2766493002: Revert of [Android] Do not restore NTPs from disk unless they are selected. (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Do not restore NTPs from disk unless they are selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/ ) Reason for revert: Broke the compile: https://build.chromium.org/p/chromium/builders/Android/builds/69977 Original issue's description: > [Android] Do not restore NTPs from disk unless they are selected. > > This also disables saving tab states for NTPs as they are not > needed for tab restore anyway (the metadata file will restore > based on URL if the state file is missing and can handle the > NTP selected case anyway). > > Sidenote...we should consider not persisting tab states to disk > that have no navigations nor any web contents state. > > BUG=702762 > > Review-Url: https://codereview.chromium.org/2757013002 > Cr-Commit-Position: refs/heads/master@{#458241} > Committed: https://chromium.googlesource.com/chromium/src/+/3c7d798abb3a42da2bdaeeb0497a47575fda9bd2 TBR=dfalcantara@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702762 Review-Url: https://codereview.chromium.org/2766493002 Cr-Commit-Position: refs/heads/master@{#458251} Committed: https://chromium.googlesource.com/chromium/src/+/28865543d686d93a737842b56b623f019af8ddac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -287 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 11 chunks +31 lines, -64 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 2 chunks +1 line, -8 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java View 1 chunk +0 lines, -214 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dmitry Titov
Created Revert of [Android] Do not restore NTPs from disk unless they are selected.
3 years, 9 months ago (2017-03-21 00:20:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766493002/1
3 years, 9 months ago (2017-03-21 00:20:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 00:28:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28865543d686d93a737842b56b62...

Powered by Google App Engine
This is Rietveld 408576698