Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Issue 2766373004: Convert the rest of chrome_public_test_apk InstrumentationTestCases to JUnit4 (Closed)
Patch Set: nits and rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
index 60719d34d9f0c58bc00bd41796f7b8ca9edadef3..a0bdf15cc2c3d5a25f2ec4cdf51df6859b4b4c88 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java
@@ -5,13 +5,19 @@
package org.chromium.chrome.browser.download;
import android.content.Context;
+import android.support.test.InstrumentationRegistry;
import android.support.test.filters.SmallTest;
-import android.test.InstrumentationTestCase;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.AdvancedMockContext;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
+import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
@@ -20,7 +26,8 @@ import java.util.UUID;
/**
* Tests of {@link SystemDownloadNotifier}.
*/
-public class SystemDownloadNotifierTest extends InstrumentationTestCase {
+@RunWith(ChromeJUnit4ClassRunner.class)
+public class SystemDownloadNotifierTest {
private MockSystemDownloadNotifier mDownloadNotifier;
private MockDownloadNotificationService mService;
@@ -60,10 +67,10 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {
}
}
- @Override
+ @Before
public void setUp() throws Exception {
- super.setUp();
- mDownloadNotifier = new MockSystemDownloadNotifier(getInstrumentation().getTargetContext());
+ mDownloadNotifier = new MockSystemDownloadNotifier(
+ InstrumentationRegistry.getInstrumentation().getTargetContext());
}
/**
@@ -74,8 +81,10 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {
@Override
public void run() {
mService = new MockDownloadNotificationService();
- mService.setContext(new AdvancedMockContext(
- getInstrumentation().getTargetContext().getApplicationContext()));
+ mService.setContext(
+ new AdvancedMockContext(InstrumentationRegistry.getInstrumentation()
+ .getTargetContext()
+ .getApplicationContext()));
mService.onCreate();
}
});
@@ -86,6 +95,7 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {
/**
* Tests that pending notifications will be handled after service is connected.
*/
+ @Test
@SmallTest
@Feature({"Download"})
@RetryOnFailure
@@ -101,12 +111,13 @@ public class SystemDownloadNotifierTest extends InstrumentationTestCase {
});
onServiceConnected();
- assertEquals(1, mService.getNotificationIds().size());
+ Assert.assertEquals(1, mService.getNotificationIds().size());
}
/**
* Tests that service will be stopped once all notifications are inactive.
*/
+ @Test
@SmallTest
@Feature({"Download"})
public void testServiceStoppedWhenAllDownloadsFinish() {

Powered by Google App Engine
This is Rietveld 408576698