tools/json_schema_compiler/js_util.py - Issue 2766363002: [Closure Externs] Handle optional params sent to an API callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/js_util.py

Issue 2766363002: [Closure Externs] Handle optional params sent to an API callback (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/js_util.py

diff --git a/tools/json_schema_compiler/js_util.py b/tools/json_schema_compiler/js_util.py

index e563b8889af0bcf03a980cdda55b42f88dfb5d30..064b40b5e28be89a08b50e431355d1cf376c076b 100644

--- a/tools/json_schema_compiler/js_util.py

+++ b/tools/json_schema_compiler/js_util.py

@@ -119,6 +119,8 @@ class JsUtil(object):

c.Append('function(')

for i, param in enumerate(function.params):

c.Concat(self._TypeToJsType(namespace_name, param.type_), new_line=False)

+ if param.optional:

+ c.Append('|undefined', new_line=False)

if i is not len(function.params) - 1:

c.Append(', ', new_line=False, strip_right=False)

c.Append('):', new_line=False)

« no previous file with comments | « tools/json_schema_compiler/js_externs_generator_test.py ('k') | no next file » | no next file with comments »