Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2766353005: Hacky fix for kernel bots (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index 40c1cd1fd326c2e9b143e2d75375a447d40675bf..081c7a128e1940b894a3fe0a08248fec49c51a60 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -3183,7 +3183,7 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfFunction(FunctionNode* function,
if (FLAG_causal_async_stacks &&
(dart_function.IsAsyncFunction() || dart_function.IsAsyncGenerator())) {
LocalScope* scope = parsed_function_->node_sequence()->scope();
- // :async_stack_trace = _asyncStackTraceHelper();
+ // :async_stack_trace = _asyncStackTraceHelper(:async_op);
const dart::Library& async_lib =
dart::Library::Handle(dart::Library::AsyncLibrary());
const Function& target = Function::ZoneHandle(
@@ -3191,9 +3191,11 @@ FlowGraph* FlowGraphBuilder::BuildGraphOfFunction(FunctionNode* function,
async_lib.LookupFunctionAllowPrivate(Symbols::AsyncStackTraceHelper()));
ASSERT(!target.IsNull());
+ // TODO(johnmccutchan): Why does this have the null value?
LocalVariable* async_op =
- scope->LookupVariable(Symbols::AsyncOperation(), true);
+ scope->child()->LookupVariable(Symbols::AsyncOperation(), false);
ASSERT(async_op != NULL);
+ ASSERT(async_op->is_captured());
body += LoadLocal(async_op);
body += PushArgument();
body += StaticCall(TokenPosition::kNoSource, target, 1);
« no previous file with comments | « runtime/lib/stacktrace.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698