Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2766323005: Fix warnings in dart2js and analyzer caused by Fasta. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Siggi Cherem (dart-lang), Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix warnings in dart2js and analyzer caused by Fasta. Committed: https://github.com/dart-lang/sdk/commit/ee591a87d2e3f64ba5e958191d34386b8d11cf97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M pkg/analyzer/lib/src/fasta/mock_element.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +9 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2769063003 Patch 1

Messages

Total messages: 7 (3 generated)
ahe
3 years, 9 months ago (2017-03-23 13:51:55 UTC) #2
jwren
On 2017/03/23 13:51:55, ahe wrote: LGTM
3 years, 9 months ago (2017-03-23 14:35:21 UTC) #3
ahe
Committed patchset #1 (id:1) manually as ee591a87d2e3f64ba5e958191d34386b8d11cf97 (presubmit successful).
3 years, 9 months ago (2017-03-23 14:39:13 UTC) #5
Siggi Cherem (dart-lang)
3 years, 9 months ago (2017-03-23 15:20:05 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698