Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2766313002: Allow webview guests to skip WAR checks in ShouldAllowOpenURL. (Closed)
Patch Set: Devlin's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
index 5a8444518041e5bdfee2854215d424deada74763..1a5845da9260813a4b0e0c6bde2473cb6d19cd01 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
@@ -613,6 +613,15 @@ bool ChromeContentBrowserClientExtensionsPart::ShouldAllowOpenURL(
return true;
}
+ // <webview> guests should be allowed to load only webview-accessible
+ // resources, but that check is done later in
+ // AllowCrossRendererResourceLoadHelper, so allow <webview> guests to proceed
+ // here and rely on that check instead. See https://crbug.com/691941.
+ if (site_url.SchemeIs(content::kGuestScheme)) {
+ *result = true;
+ return true;
+ }
+
if (WebAccessibleResourcesInfo::IsResourceWebAccessible(to_extension,
to_url.path())) {
*result = true;

Powered by Google App Engine
This is Rietveld 408576698