Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js

Issue 2766313002: Allow webview guests to skip WAR checks in ShouldAllowOpenURL. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js b/chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js
index 5ba391dcb96fcff6bbb2dbad503394b450fe3463..69b02aecb8ef8d5882bb13cd82177b297778bd99 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js
@@ -8,6 +8,8 @@ embedder.guestURL = '';
window.runTest = function(testName) {
if (testName == 'testLoadWebviewAccessibleResource') {
testLoadWebviewAccessibleResource();
+ } else if (testName == 'testReloadWebviewAccessibleResource') {
+ testReloadWebviewAccessibleResource();
} else {
window.console.log('Incorrect testName: ' + testName);
chrome.test.sendMessage('TEST_FAILED');
@@ -32,6 +34,30 @@ function testLoadWebviewAccessibleResource() {
webview.src = embedder.guestURL;
};
+function testReloadWebviewAccessibleResource() {
+ var webview = document.querySelector('webview');
+ var didReload = false;
+
+ webview.addEventListener('loadstop', function() {
+ if (didReload) {
lazyboy 2017/03/22 21:54:03 nit: I think we've always done 2 space indentation
alexmos 2017/03/22 23:56:39 Done.
+ // Check that the webview loaded the content correctly.
+ webview.executeScript(
+ {code: 'document.body.innerText'}, function(result) {
+ if (result == 'Foo')
+ chrome.test.sendMessage('TEST_PASSED');
+ else {
+ console.log('webview content is incorrect: ' + result);
+ chrome.test.sendMessage('TEST_FAILED');
+ }
+ });
+ } else {
+ webview.executeScript({code: 'location.reload();'});
lazyboy 2017/03/22 21:54:02 I'm assuming this causes ShouldAllowOpenURL()?
alexmos 2017/03/22 23:56:39 Yes, exactly. ShouldAllowOpenURL is called from O
+ didReload = true;
+ }
+ });
+ webview.src = '/assets/foo.html';
+}
+
onload = function() {
chrome.test.getConfig(function(config) {
embedder.guestURL =

Powered by Google App Engine
This is Rietveld 408576698