Allow webview guests to skip WAR checks in ShouldAllowOpenURL.

chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_content_browser_client_extensions_part.h"
 
 #include <stddef.h>
 
 #include <set>
 
@@ skipping 595 matching lines @@
   // Note that this is intentionally done after the check for blob: and
   // filesystem: URLs above, for consistency with the renderer-side checks
   // which already disallow navigations from chrome URLs to blob/filesystem
   // URLs.
   if (site_url.SchemeIs(content::kChromeUIScheme) ||
       site_url.SchemeIs(chrome::kChromeSearchScheme)) {
     *result = true;
     return true;
   }
 
+  // <webview> guests should be allowed to load only webview-accessible
+  // resources, but that check is done later in
+  // AllowCrossRendererResourceLoadHelper, so allow <webview> guests to proceed

[Devlin, 2017/03/22 21:58:56]

This makes me a bit sad... what would need to happen to combine these checks? 
(I don't trust my knowledge of when each is called.)

[alexmos, 2017/03/22 23:56:39]

I think this one is called on the UI thread only for navigations, before the
request is kicked off, but only on the OpenURL/transfer path. 
AllowCrossRendererResourceLoad happens on the IO thread for all network
requests, including subresources.  So they're not exactly the same, and I think
we had issues doing some of those checks on the IO thread due to not having some
necessary info there.  One thing that might help is PlzNavigate, as (1) it will
remove the transfer path, so we won't need to worry about this for transfers
anymore, and (2) it already reuses AllowCrossRendererResourceLoadHelper for main
frame requests, which it calls from the UI thread in
ExtensionNavigationThrottle.  I think we could at least combine the checks here
with those in ExtensionNavigationThrottle.  I definitely agree we have too many
places enforcing these things, so this is something we need to think about for
sure.

+  // here and rely on that check instead.  See https://crbug.com/691941.
+  if (site_url.SchemeIs(content::kGuestScheme)) {
+    *result = true;
+    return true;
+  }
+
   if (WebAccessibleResourcesInfo::IsResourceWebAccessible(to_extension,
                                                           to_url.path())) {
     *result = true;
     return true;
   }
 
   if (!site_url.SchemeIsHTTPOrHTTPS() && !site_url.SchemeIs(kExtensionScheme)) {
     RecordShowAllowOpenURLFailure(
         FAILURE_SCHEME_NOT_HTTP_OR_HTTPS_OR_EXTENSION);
 
@@ skipping 170 matching lines @@
     command_line->AppendSwitch(switches::kExtensionProcess);
   }
 }
 
 void ChromeContentBrowserClientExtensionsPart::ResourceDispatcherHostCreated() {
   content::ResourceDispatcherHost::Get()->RegisterInterceptor(
       "Origin", kExtensionScheme, base::Bind(&OnHttpHeaderReceived));
 }
 
 }  // namespace extensions