chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 2766263007: Verify that previous_selected_line is within bounds before passing to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2766263007: Verify that previous_selected_line is within bounds before passing to (Closed)

Patch Set: Resets selected_line_ (instead of calling SetSelectedLine) when deleting suggestion. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index b800e88cc141934f36e113db3cb1c86beb358449..481f92aee99302ed5b17271b3d9645cfd0026db7 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -359,7 +359,7 @@ bool AutofillPopupControllerImpl::RemoveSuggestion(int list_index) {

elided_values_.erase(elided_values_.begin() + list_index);

elided_labels_.erase(elided_labels_.begin() + list_index);

- SetSelectedLine(base::nullopt);

+ selected_line_.reset();

if (HasSuggestions()) {

delegate_->ClearPreviewedForm();

@@ -400,6 +400,7 @@ void AutofillPopupControllerImpl::SetSelectedLine(

auto previous_selected_line(selected_line_);

selected_line_ = selected_line;

Evan Stade 2017/03/27 17:21:16 nit: no need for this extra newline

csashi 2017/03/27 17:25:22 Done.

view_->OnSelectedRowChanged(previous_selected_line, selected_line_);

if (selected_line_) {

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc » ('j') | no next file with comments »